Repository navigation
Conversation
Previously every agent was sent as null in providerResolutions, so the server chose the provider itself and imported agents ended up with a null provider or the profile's default model. Send each agent's own profileName and modelName from the bundle instead, falling back to null when the provider is missing or incomplete. Closes itential#228 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously every agent was sent as null in providerResolutions, so the server chose the provider itself and imported agents ended up with a null provider or the profile's default model. Send each agent's own profileName and modelName from the bundle instead, falling back to null when the provider is missing or incomplete.
Closes #228
Description
import agent-projectsentnullfor every agent inproviderResolutions, so the platform chose the LLM provider itself. Imported agents could get the profile's default model orprovider: null, even when a profile with the same name existed on the destination.Each entry is now built from the agent's own
providerin the bundle, so the platform resolves it by name and keeps the source model. The destination is expected to have a profile with the same name as the source. Mapping to a differently named profile is not part of this change.Tool authorization (
unauthorizedReferenceId) is a separate problem and stays in #225.Type of Change
Changes Made
pkg/services/agent_projects.go: newagentProviderResolutionhelper builds{ "profileName", "modelName" }from an agent'sprovider.Importuses it instead of sendingnil. An agent with no provider, or one missing either value, is still sent asnull.pkg/services/agent_projects_test.go: newTestAgentProjectService_Import_ProviderResolutions.Testing
go test ./...,gofmtandgo vetpass.POST /agent-project-service/project-bundles/importand checks four agents: a full provider, a model name only, no provider, and an agent identified byuuidinstead of_id.Checklist
make setupor relevant profiletype: subject)enhancement,bug,documentation,refactor,chore)