Repository navigation
Correct the live view media reason row and timeout warning - #698
Open
robertjamesprior wants to merge 2 commits into
Open
robertjamesprior wants to merge 2 commits into
robertjamesprior wants to merge 2 commits into
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
The `media` reason matches a peer that reaches neither `connected` nor `completed` inside its bound — `completed` arrives without `connected` when gathering is already done. The warning under the watchdog example describes the client before this fix, where `checking` cleared the only watchdog, so scope it to images without the connect-failure fix.
robertjamesprior
marked this pull request as ready for review
October 14, 2026 18:03
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
mediarow said ICE never reachedchecking, and the warning under the watchdog example said a connection that stalls after negotiation never emitsKERNEL_CONNECTION_TIMEOUT. Both describe the client before kernel-images#417.With that fix the media bound stays armed past
checkingand clears onconnectedorcompleted, so a peer that stalls aftercheckingdoes report — andcompletedcounts as success because ICE can reach it withoutconnectedwhen gathering is already done.Docs-only. Ships with kernel-images#417; the page tolerates images that predate it, and the warning is now scoped to them. No other rows change. Prose and table edits only — Mintlify has no build step, and I did not run
mintlify devlocally.Note
Low Risk
Documentation-only prose and table edits in
live-view.mdx; no runtime or API behavior changes.Overview
Updates Live View parent-frame docs to match post–connect-failure fix client behavior (kernel-images#417).
The
mediareasonrow now says the media-stage timeout fires when ICE never reachesconnectedorcompleted(including stalls afterchecking), not when it fails to reachchecking. The watchdog guidance is scoped to images without that fix: only on those older images does clearing the timeout at negotiation start mean a post-negotiation stall may never emitKERNEL_CONNECTION_TIMEOUT.Reviewed by Cursor Bugbot for commit df0367d. Bugbot is set up for automated code reviews on this repo. Configure here.