Repository navigation
Correct the media stage bound to connected - #704
Open
robertjamesprior wants to merge 2 commits into
Open
robertjamesprior wants to merge 2 commits into
robertjamesprior wants to merge 2 commits into
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
robertjamesprior
marked this pull request as ready for review
October 15, 2026 00:23
The snippet remounted 15s after mount. The client's connect bounds run in sequence and sum to 23s, so an embedder following the example tore the frame down before the client could report which stage stalled — including media, the stage most likely to have stalled. Also correct the note about KERNEL_CONNECTION_TIMEOUT never firing once negotiation begins. The media bound stays armed past `checking` until ICE reaches `connected`, so a connect that stalls in between does report one; what never emits it is a viewer whose frames stop after it connected.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two corrections to the live view embedding guidance.
The
mediareason row. It said the bound expires if ICE never reachedchecking. Since kernel-images#417 the client keeps the media bound armed throughconnected, so it expires only if ICE never arrives there. An embedder branching onreasonwould otherwise expectmediato fire earlier than it does.The example watchdog. It remounted 15s after mount. The client's connect bounds run in sequence — transport, then signaling, then media — and sum to 23s, so an embedder following the snippet tore the frame down before the client could report which stage stalled. This is the media stage, which is the one most likely to have stalled, so the guidance was suppressing the diagnosis it was written to enable. The example now uses 25s and the prose states the constraint.
The note claiming
KERNEL_CONNECTION_TIMEOUTstops firing once negotiation begins is also corrected: the media bound stays armed pastcheckinguntil ICE reachesconnected, so a connect stalling in between does report one. What never emits it is a viewer whose frames stop after it connected.Paired with kernel-images#472, which shortens the media bound so the budget fits. Merge order doesn't matter for the docs themselves, but the two describe the same client.
Docs only.
mint broken-linkspasses locally on the pinned 4.2.930, which is what CI runs.Note
Low Risk
Documentation-only changes to live view integration guidance; no runtime or API behavior changes in this repo.
Overview
Updates Live View embedder docs so they match current client behavior (post kernel-images#417).
The
mediareasonis documented as firing when ICE never reachesconnected(notchecking), so handlers that branch onreasonexpect the right stage.The “Detecting a viewer that never starts” section now states that connect bounds run in sequence (transport → signaling → media, 23s total) and that remount timers must exceed that window. The sample watchdog is 25s (was 15s).
KERNEL_CONNECTION_TIMEOUTguidance is revised: the media bound clears when ICE hitsconnected, and timeouts only apply while negotiation is still in progress—not after frames were already playing.Reviewed by Cursor Bugbot for commit 58849c9. Bugbot is set up for automated code reviews on this repo. Configure here.