Repository navigation
Update Hypeman build toolchains to Go 1.26.10 - #525
Conversation
chruffins
left a comment
There was a problem hiding this comment.
Bugs
scripts/utm/bootstrap-dev-environment.sh:52— the guardgrep -q "go1.2"matchesgo1.25.4, so machines that already have a 1.2x toolchain skip the install and never reach the newGO_VERSIONon line 55. compare the installed version againstGO_VERSIONbefore skipping. the guard predates this PR, but the bump is what it needs to deliver.
Questions
.github/actions/setup-stlc/action.yml:20—go-version: "stable"floats and is not pinned. is SDK generation meant to be in the 1.26.10 alignment scope? this line is not in the diff.
Structural / Maintainability
.github/workflows/test.yml:92— the same version is hand-written in ten places: six workflow pins,go.mod, the builder Dockerfile, the CloudFormation download, and the bootstrap script. this duplication predates the PR.vuln-remediation.yml:16already usesgo-version-file: 'go.mod', so the workflows could follow it. suggested as a follow-up, not a blocker.
Nits
DEVELOPMENT.md:9,:19,:371— still say "Go 1.25.4+". update them to 1.26.10+.
coverage — all 7 changed files inspected. repo-wide grep found no other executable 1.25 pins; remaining hits are test fixtures (golang:1.21, golang:1.22 examples) and unrelated text. go1.26.10 is present in the go.dev release index, and the Dockerfile and tarball names are correct. not verified: the CVE-2026-111943 mitigation claim, rebuilt Caddy/guest-agent/init binaries, macOS builds, full builder-image builds, cfn-lint.
status: review complete; read-only analysis; no tests run
-->
✱ stlc build✅ go code · compare
✅ python code · compare
✅ typescript code · compare
Diagnostics: ❗ 0 new / 1 total error, 💡 0 new / 5 total note
Build metadata
This comment is auto-generated by stlc and is kept up to date as you push. |
Summary
go.modin all seven setup-go steps, including SDK generation, instead of duplicating pins or floating onstable.Validation
go build -tags containers_image_openpgp ./....lib/ingress/...,lib/system/...anddeploy/aws/cloudformation.kvmrunner label accepted, and CloudFormation Go tests.Rollout
Release/rebuild and deploy after merging, with the infrastructure toolchain/trust updates. No running hosts or services were changed.
Note
Medium Risk
Toolchain-wide Go upgrade affects all builds, releases, and bootstrap paths; CI alignment reduces drift but embedded binaries still need release rebuild after merge.
Overview
Bumps the module and build toolchain to Go 1.26.10 (including the CVE-2026-111943 certificate-chain fix) and makes
go.modthe single source of truth for CI: everyactions/setup-gostep now usesgo-version-file: go.modinstead of duplicated pins orstable.Explicit 1.26.10 pins remain where Actions does not read
go.mod—the generic builder Dockerfile, AWS CloudFormation branch-install curl, andscripts/utm/bootstrap-dev-environment.sh, which also fixes Go detection (GOTOOLCHAIN=local go env GOVERSION), downloads to a temp file before replacing/usr/local/go, and prepends/usr/local/go/binonPATH. DEVELOPMENT.md prerequisite text is updated to Go 1.26.10+.Reviewed by Cursor Bugbot for commit ff894c3. Bugbot is set up for automated code reviews on this repo. Configure here.