Skip to content

Bound network header capture and isolate expiry accounting - #486

Merged
Sayan- merged 3 commits into
mainfrom
hypeship/network-capture-limits
Oct 23, 2026
Merged

Sayan- merged 3 commits into
mainfrom
hypeship/network-capture-limits

Conversation

@Sayan-

@Sayan- Sayan- commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Fast follow items from #462

  • Expired requests could decrement a replacement capture's network-idle count, and ordinary requests could exceed the header-correlation limit. Bind request accounting to its original capture and enforce the 8,192-entry limit for both request-first and ExtraInfo-first admission.
  • After saturation, new chains use base request headers until telemetry restarts or CDP reconnects. Already admitted chains continue collecting headers. This conservative fallback prevents a dropped early header event from shifting later headers onto the wrong redirect hop. Request, response, and failure events still publish in order. The response API and body limits are unchanged.

Document the existing five-minute request retention and the scope of the capacity limit: it bounds the header registry, not all in-flight requests or publishers.

Testing

  • Regressions reproduce premature network-idle publication after capture replacement and growth beyond 8,192 entries, then pass with the fixes.
  • Saturation coverage checks redirect order, success/failure delivery, base-header fallback, late headers for admitted chains, and cleanup. An ExtraInfo-first regression reproduces incorrect redirect header attribution and verifies recovery after capture reset.
  • The race-enabled Chromium collector suite and related API/event suites pass locally. Full container image startup and installed bundled-extension tests were not rerun for this follow-up.

Note

Cursor Bugbot is generating a summary for commit c5859e2. Configure here.

@Sayan-
Sayan- marked this pull request as ready for review October 23, 2026 16:58
@Sayan-
Sayan- requested review from meliaj and tnsardesai October 23, 2026 18:46
@Sayan-
Sayan- merged commit e45bd7a into main Oct 23, 2026
12 checks passed
@Sayan-
Sayan- deleted the hypeship/network-capture-limits branch October 23, 2026 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants