Repository navigation
feat(AIC-3685)!: make the internal provider helpers private - #224
Merged
Merged
Conversation
build_prompt, build_tool_mcp and partition_tools (launchdarkly_ai_claude_agents) and build_output_type (launchdarkly_ai_openai_agents) are no longer exported. They are renamed with a leading underscore where they are defined. No deprecated aliases: the packages are 0.x, so this ships as a minor bump. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jeffdupont
marked this pull request as ready for review
October 27, 2026 17:53
aknight-ld
approved these changes
Oct 27, 2026
apucacao
approved these changes
Oct 27, 2026
…ate-helpers # Conflicts: # packages/openai-agents/api-report/launchdarkly_ai_openai_agents.txt # packages/openai-agents/src/launchdarkly_ai_openai_agents/__init__.py
jeffdupont
added a commit
that referenced
this pull request
Oct 28, 2026
Conflicts resolved by keeping both sides: - claude-agents: ClaudeNativeGraphOptions export plus main's skills handler. - openai-agents: OpenAINativeGraphOptions plus main's create_openai_agents_handler rename; build_output_type stays private, as main made it in #224. - opencode-agents handler: main's secrets import plus this branch's NativeTool. - API reports regenerated with make api-report. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: AIC-3685
What changed
launchdarkly_ai_claude_agents:build_prompt,build_tool_mcpandpartition_toolsare removed from__all__and the package root, and renamed_build_prompt,_build_tool_mcp,_partition_toolsinhandler.py. Internal callers (handler.py,native_graph.py), tests andagents.mdare updated.launchdarkly_ai_openai_agents:build_output_typeis removed from__all__and the package root, and renamed_build_output_typeinutils.py. Tests are updated.make api-report.Pre-1.0 cleanup: these four names are no longer importable. Nothing has shipped as 1.0, so there is no compatibility promise to keep. The
!only gives the 0.x minor bump. The monorepo API-surface lists (api-surface/python/) are updated in a companion ai-sdks-monorepo PR.vercel-agentshas its own, unrelatedbuild_output_typeinhandler.py(different signature, not exported, not in its API report). It is left unchanged.Testing
make api-report(wrote 14 reports) andmake api-report-check: passmake lint,make format-check,make typecheck: passmake test: 3631 passed, 2 failed. The 2 failures (packages/client/tests/test_lifecycle.py::TestInitClientSDKKeyPath::test_uses_options_sdk_key_over_env_varand::test_retries_after_a_failed_init_instead_of_replaying_it) fail the same way on an untouchedorigin/maincheckout in the same location. They pick up staging URIs from a local.env, so they are a local environment issue, not caused by this change.🤖 Generated with Claude Code
Note
Overview
Breaking (pre-1.0): Several provider helper functions are no longer part of the public Python API.
In
launchdarkly_ai_claude_agents,build_prompt,build_tool_mcp, andpartition_toolsare renamed to_build_prompt,_build_tool_mcp, and_partition_tools, dropped from__init__/__all__, and removed from the generated API report.launchdarkly_ai_openai_agentsdoes the same forbuild_output_type→_build_output_typeinutils.py.Call sites inside each package (
handler.py,native_graph.py), tests, andagents.mdare updated to the private names. No deprecated aliases—external code that imported these helpers must stop or copy the logic. API reports were regenerated withmake api-report.Reviewed by Cursor Bugbot for commit 11fd3f6. Bugbot is set up for automated code reviews on this repo. Configure here.