Repository navigation
fix(SESF-74): count a stripped row that starts with the reply as answered - #97
Conversation
…ered Boilerplate stripping can remove a turn's whole user part (for example a ci-monitor-event), so the stored document starts with 'Assistant: '. dedupe_turns._has_reply only matched '\n\nAssistant: ', so these rows counted as user-only: the live dry run reported 2,598 user-only turns instead of 898, and apply re-parsed their sessions with no effect.
|
@coderabbitai review |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 23 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
SESF-74 follow-up.
Boilerplate stripping can remove a turn's whole user part (for example a
<ci-monitor-event>), so the stored document starts withAssistant:.dedupe_turns._has_replymatched only\n\nAssistant:, so these rows counted as user-only.applyre-parsed those sessions with no effect, since the rebuilt turn has the samedoc_id.keep-longestcould prefer a shorter row with a user line over a stripped row with the reply.Change
_has_replyalso accepts a document that starts withAssistant:.Checks
ruff check .clean.pytest: 817 passed, 120 skipped. New test intests/test_dedupe_turns.py.