Skip to content

fix(SESF-74): count a stripped row that starts with the reply as answered - #97

Merged
lbruton merged 1 commit into
mainfrom
fix/SESF-74-reply-check
Oct 30, 2026
Merged

lbruton merged 1 commit into
mainfrom
fix/SESF-74-reply-check

Conversation

@lbruton

@lbruton lbruton commented Oct 30, 2026

Copy link
Copy Markdown
Owner

SESF-74 follow-up.

Boilerplate stripping can remove a turn's whole user part (for example a <ci-monitor-event>), so the stored document starts with Assistant: . dedupe_turns._has_reply matched only \n\nAssistant: , so these rows counted as user-only.

  • The live dry run reported 2,598 user-only turns instead of 898.
  • apply re-parsed those sessions with no effect, since the rebuilt turn has the same doc_id.
  • keep-longest could prefer a shorter row with a user line over a stripped row with the reply.

Change

_has_reply also accepts a document that starts with Assistant: .

Checks

  • ruff check . clean.
  • pytest: 817 passed, 120 skipped. New test in tests/test_dedupe_turns.py.
  • Live dry run: 0 duplicate groups, 898 user-only turns, which matches an independent re-parse (694 from deleted transcripts, 204 genuine).

…ered

Boilerplate stripping can remove a turn's whole user part (for example a
ci-monitor-event), so the stored document starts with 'Assistant: '.
dedupe_turns._has_reply only matched '\n\nAssistant: ', so these rows
counted as user-only: the live dry run reported 2,598 user-only turns
instead of 898, and apply re-parsed their sessions with no effect.
@lbruton

lbruton commented Oct 30, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 23 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 6570613 and 72ac582.

Files selected for processing: 2
  • dedupe_turns.py
  • tests/test_dedupe_turns.py
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T00:35:26.774814Z 72ac582 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@lbruton
lbruton merged commit 95c889a into main Oct 30, 2026
9 checks passed
@lbruton
lbruton deleted the fix/SESF-74-reply-check branch October 30, 2026 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant