Repository navigation
Conversation
3 tasks done
azahnen
requested changes
May 22, 2026
azahnen
left a comment
Collaborator
There was a problem hiding this comment.
- TemporalExtent
- should be UTC ISO datetime (
YYYY-MM-DDTHH:mm:ss.sssZ) - use
DateTimeFormatter.ISO_INSTANT.parseto validate - add methods for start and end (
@Value.Derived,@JsonIgnore) that returnInstant(Instant.from(DateTimeFormatter.ISO_INSTANT.parse))
- should be UTC ISO datetime (
- SpatialExtent
toBoundingBoxshould be moved here withnativeCrsas parameter
- FeatureProvider*
- it seems there is a lot of duplicated code, move to
AbstractFeatureProviderwhere appropiate
- it seems there is a lot of duplicated code, move to
Contributor
Author
|
Thanks, should be taken care of now. |
azahnen
force-pushed
the
ldp-94-ldproxy-extent-handling
branch
2 times, most recently
from
October 31, 2026 18:52
5a42e4f to
219a7ce
Compare
azahnen
force-pushed
the
ldp-94-ldproxy-extent-handling
branch
from
October 31, 2026 19:20
219a7ce to
deab143
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the xtraplatform-spatial part of ldproxy/ldproxy#1171: spatial and temporal extents can be configured in the providers instead of only at the API level.
Configuration
Feature providers
extent.spatialandextent.temporalon the provider and on each type. A configured extent is never computed. Each part of a type extent replaces the same part of the provider extent.yyyy-MM-dd, UTC, end inclusive) or date-times with offset; a missing bound is open.computed: trueon a type discards an inherited fixed extent.computed: falseis rejected, andcomputedmust not be combined with coordinates or bounds.Tile providers (
tilesetDefaultsandtilesets, coordinates always in CRS84)boundsfrom the MBTiles metadata is used.Query restriction (SQL providers only,
queryGeneration)restrictToSpatialExtentandrestrictToTemporalExtent(both defaulttrue) addS_INTERSECTS/T_INTERSECTSpredicates for fixed extents to all queries for multiple features. Queries for a single feature by id are not restricted.Behavior changes
containsKeycheck madegetSpatialExtent(andgetFeatureCountfor GraphQL) always return nothing; they now return computed values.Notes
FeatureTypeConfiguration.getExtent()conflicts withgetExtent()in ldproxy'sFeatureTypeConfigurationOgcApi; this is resolved in the related ldproxy PR.@since v4.9.SpatialExtentSpec,TemporalExtentSpec,FeatureTypeExtentSpec,ExtentFiltersSpec,TileProviderHttpExtentSpecand extent cases inFilterEncoderSqlSpec(SQL text for PostGIS only).