Repository navigation
fix single-shot queries exceeding the per-query maximum for concatenated feature types - #678
Merged
Merged
Conversation
…ted feature types For a feature type with more than one main table (type-level concat), every main table was capped with the full maxFeaturesPerSubQuery, so a single-shot query could return n times the maximum. Bounded counts, one main table after the other, now distribute the maximum across the main tables; tables are skipped once it is reached. Types with a single main table are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a feature type with more than one main table (type-level concat), every main table was capped with the full maxFeaturesPerSubQuery, so a single-shot query could return n times the maximum. Bounded counts, one main table after the other, now distribute the maximum across the main tables; tables are skipped once it is reached. Types with a single main table are unchanged.