Repository navigation
Run the full desktop E2E on pull requests and fix its second cycle - #80
Merged
Merged
Conversation
Exit now remembers the group dragged together during a cycle, so the next cycle's startup brought the surviving helper windows back as one group. Check that the group was remembered, then forget it before the next startup.
Pull requests ran the one-cycle Quick profile, so a defect that only shows after WindowTabs restarts first failed the release. Run Full, as the release does, on pull requests and as the manual default; it adds about a minute.
leafOfTree
changed the title
WindowTabs also keeps each window's group on the window itself, so helpers that survive into the next cycle came back grouped even with the settings record removed. Check that exit kept it, then remove it with the remembered group.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Full desktop E2E failed at cycle 2 startup with "Actual startup did not discover all three helper windows".
Exit now remembers groups made by dragging tabs (
rememberedGroupsin the settings file). The E2E keeps the surviving helper windows, with the same titles, across cycles and reuses the saved settings, so the second startup correctly brought them back as one group while the test expected three separate strips.After each cycle's normal exit the test now checks that the dragged group was remembered, then removes the record so the next cycle starts with the helpers apart and drags them together again.
This PR is the first to run Full as its own check, which exercises the fix.
Pull requests now run the Full profile (two cycles with exit and restart) instead of Quick, the same profile the release runs, so this kind of failure shows up on the pull request. Full adds about a minute and runs alongside the regression groups. The check is now named Desktop E2E (Full); manual dispatch defaults to Full as well.