Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mp_api/client/mprester.py
Original file line number Diff line number Diff line change
Expand Up @@ -1399,7 +1399,8 @@ def get_entries_in_chemsys(
)
n = len(unmixed)
entries = apply_corrections(
MaterialsProjectDFTMixingScheme(),
# strict structure matching, as for MP's pre-built phase diagrams
MaterialsProjectDFTMixingScheme(fuzzy_matching=False),
unmixed,
description="Re-mixing GGA(+U)/r2SCAN entries",
log=f"Re-mixing {n:,} GGA(+U)/r2SCAN entries onto a common energy scale",
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ classifiers = [
]

dependencies = [
"pymatgen>2024.2.20",
"pymatgen>=2026.9.23", # MaterialsProjectDFTMixingScheme fix for local re-mixes
"requests>=2.23.0",
"monty>=2024.12.10",
"emmet-core>=0.88.0",
Expand Down
13 changes: 13 additions & 0 deletions tests/client/test_mprester.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
from mp_api.client import MPRester
from mp_api.client.core import MPRestError, MPRestWarning
from mp_api.client.core.settings import _DEFAULT_ENDPOINT
from mp_api.client.routes.materials.thermo import ThermoRester

try:
from mp_api.client.contribs import ContribsClient as contribs_client
Expand Down Expand Up @@ -331,6 +332,18 @@ def test_get_entries_in_chemsys(self, mpr):
):
mpr.get_entries_in_chemsys([Element.from_Z(1 + i).name for i in range(10)])

def test_get_entries_in_chemsys_remix_matches_served(self, mpr, monkeypatch):
"""The client-side re-mix (used when MP has no pre-built phase diagram) matches
MP's pre-built phase diagram rules."""
served = mpr.get_entries_in_chemsys("O")
monkeypatch.setattr( # force the re-mix
ThermoRester, "get_phase_diagram_from_chemsys", lambda *args, **kwargs: None
)
remixed = mpr.get_entries_in_chemsys("O")
assert {str(e.entry_id): e.energy_per_atom for e in remixed} == pytest.approx(
{str(e.entry_id): e.energy_per_atom for e in served}
)

def test_get_entries_in_chemsys_mixed_hull(self, mpr):
"""Mixed GGA(+U)/r2SCAN entries must all sit on one energy scale (issue #1104).

Expand Down
Loading