Repository navigation
Add displays for topologies - #2143
Open
nmolinamounier wants to merge 1 commit into
Open
nmolinamounier wants to merge 1 commit into
nmolinamounier wants to merge 1 commit into
Conversation
nmolinamounier
force-pushed
the
topology-displays
branch
from
October 24, 2026 10:47
a2ff513 to
2e40f3e
Compare
nmolinamounier
marked this pull request as draft
October 24, 2026 16:33
nmolinamounier
marked this pull request as ready for review
October 26, 2026 20:58
nmolinamounier
force-pushed
the
topology-displays
branch
from
October 26, 2026 21:02
e0b18bf to
07a70c7
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes #758 by adding extra display arguments to topologies, in the same way as orders in math-comp.
A new type
fdisp_tis added infilter.v, and every topology is associated with an instance offdisp_t, which can be used in notations for proper display.Since it is common to define specific topologies in terms of more generic ones,
with_fdisp d' Thas the same topology asT, but with displayd'.By default, displays aren't shown on common topology functions (
nbhs,open, etc.). When needed, the moduleExplicitNbhsDisplayscan be imported to make them explicit.This PR requires changing every single definition involving a filtered type to add a display argument, hence its very large footprint.
About order topologies : right now, order topologies have two arguments for topology and order displays respectively. I tried merging them into a record, but this doesn't seem to play well with canonical structure inference ; we should discuss this.
Checklist
CHANGELOG_UNRELEASED.mdReference: How to document
Merge policy
As a rule of thumb:
all compile are likely to be merged as they are into master.
Reminder to reviewers