Skip to content

Add displays for topologies - #2143

Open
nmolinamounier wants to merge 1 commit into
math-comp:masterfrom
nmolinamounier:topology-displays
Open

nmolinamounier wants to merge 1 commit into
math-comp:masterfrom
nmolinamounier:topology-displays

Conversation

@nmolinamounier

@nmolinamounier nmolinamounier commented Oct 24, 2026 •

Copy link
Copy Markdown
Collaborator
Motivation for this change

Fixes #758 by adding extra display arguments to topologies, in the same way as orders in math-comp.

A new type fdisp_t is added in filter.v, and every topology is associated with an instance of fdisp_t, which can be used in notations for proper display.

Since it is common to define specific topologies in terms of more generic ones, with_fdisp d' T has the same topology as T, but with display d'.

By default, displays aren't shown on common topology functions (nbhs, open, etc.). When needed, the module ExplicitNbhsDisplays can be imported to make them explicit.

This PR requires changing every single definition involving a filtered type to add a display argument, hence its very large footprint.

About order topologies : right now, order topologies have two arguments for topology and order displays respectively. I tried merging them into a record, but this doesn't seem to play well with canonical structure inference ; we should discuss this.

Checklist
  • appended entries in the relevant sections of CHANGELOG_UNRELEASED.md
  • Fix the current state of order topologies (?)
  • Bikeshed notations and naming
  • added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are likely to be merged as they are into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@nmolinamounier
nmolinamounier marked this pull request as draft October 24, 2026 16:33
@nmolinamounier
nmolinamounier marked this pull request as ready for review October 26, 2026 20:58
@nmolinamounier nmolinamounier added this to the 1.20.0 milestone Oct 26, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Printing specialized notations

1 participant