Repository navigation
Python: correct harness file-memory configuration guidance - #9670
Open
LI (ktz03) wants to merge 1 commit into
Open
LI (ktz03) wants to merge 1 commit into
LI (ktz03) wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documentation matches the existing factory configuration and session-scoping behavior, with no unresolved issues.
No open issues 🎉
What changed in this PR
Corrects the harness sample’s file-memory guidance to match the existing factory configuration. This is documentation-only; runtime behavior is unchanged.
Changes:
- Replaces the stale provider name with
FileMemoryProviderand clarifies that it is enabled by default. - Documents the default
{cwd}/agent-file-memorystore root,file_memory_storeparameter, anddisable_file_memoryflag.
| File | Description |
|---|---|
python/samples/02-agents/harness/README.md |
Corrects the file-memory feature entry and configuration guidance. |
Review effort: Balanced
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
The harness sample overview describes file memory as an optional
MemoryContextProviderenabled by passingmemory_store. The current factory addsFileMemoryProviderby default and exposesfile_memory_storeanddisable_file_memoryinstead.Description & Review Guide
create_harness_agentsignature and file-memory provider assembly. Static source/documentation checks were performed; no harness run, filesystem behavior test, build, or model call was executed.Related Issue
N/A - trivial change. This corrects stale provider and configuration names and documents defaults already specified by the existing factory.
AI Assistance
AI assistance details: Codex: documentation and this PR description.
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.