Repository navigation
chore: mirror js tests and implementation - #3270
Closed
Pavel Feldman (pavelfeldman) wants to merge 3 commits into
Closed
Pavel Feldman (pavelfeldman) wants to merge 3 commits into
Pavel Feldman (pavelfeldman) wants to merge 3 commits into
Conversation
Port every test in upstream's tests/registry.md to tests/async and
tests/sync, named after its id and title, or list it in
tests/upstream_not_ported.txt with the reason.
scripts/check_test_registry.py checks this in CI. The older tests move
to tests/{async,sync}/legacy.
Fix the client bugs that the ports found, so that the same tests pass
as with Node.js, and roll the driver to 1.65.0-alpha-2026-10-17.
CI runs the tests in parallel with pytest-xdist, on fewer bots.
test.sh runs the library tests under xvfb.
Compare playwright/_impl with packages/playwright-core/src/client file by
file and resolve the deviations in favor of JS: logic and order of
operations, protocol calls and parameters, guards, error messages, and
helpers with their modules. The generated channels pass the protocol's
internal flag, as getMetainfo() does. Python-only machinery stays: the
sync API, the expect_* context managers, and stack capture.
Among the bugs fixed on the way: a failed raw headers call hung later
calls; route times=0 meant unlimited; route.continue_(headers={}) kept
the headers; await on the server side of a WebSocket route raised
TypeError; a sync route_web_socket handler could not call the API;
detached frames stayed in child_frames; rewriting an error could raise
TypeError and leave a wait hanging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.