Repository navigation
fix: ignore CancelledError in sync event listener done callback - #3271
Closed
Reginald Alfret V (reginaldalfret) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3266
Summary
In
playwright/_impl/_connection.py,_done_callbackwas callingfuture.exception()unconditionally. In Python asyncio, calling.exception()on a cancelled future raisesasyncio.CancelledError. When exitingsync_playwright()with pending tasks (such as an unanswered route handler), cancelling the task caused an unhandledCancelledErrorto be logged from the event loop callback.Changes
Connection.dispatch, guarded_done_callbackwithif future.cancelled(): returnprior to inspectingfuture.exception().test_sync_event_listener_cancelled_futureintests/sync/test_sync.pyverifying that cancelled futures attached to event listeners do not raise unhandled errors.