Repository navigation
fix(ci): check public text against a private denylist (ENG-3469) - #72
Closed
lucas-koontz wants to merge 5 commits into
Closed
lucas-koontz wants to merge 5 commits into
lucas-koontz wants to merge 5 commits into
Conversation
Refs: ENG-3469
lucas-koontz
marked this pull request as ready for review
October 26, 2026 05:39
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User story
As an engineer publishing changes in a public repository,
I want GitHub to check public text against a private list,
So that restricted names and private repository details are caught before merge and soon after a text edit.
Why this matters
Text copied from tickets can put a restricted name into a PR title, branch name, commit message or comment, and nobody notices until it is public. This adds a shared scanner that fails the PR when current text matches a private pattern, and fails a separate audit run for issues, comments and reviews. It runs after GitHub saves the text, so it catches a disclosure but cannot prevent or erase it.
Release trains merge by squash, so each train lists every earlier train's commits again. The scanner skips commits that the newest earlier merged PR from the same branch into the same base already carried, and checks the rest. Without that, one old commit message would fail every later train. A PR past the PR endpoint's 250-commit limit lists its commits through the compare endpoint, with count checks. The release-train PR description now lists only the commits since the last merged train too, so a shipped commit's subject cannot fail a later train through the description.
Test plan
docs/public-text.md.Ships with
Callers: mindsdb/anton#664, mindsdb/cowork-server#771, mindsdb/cowork#1310.
Merge order: this PR first. Then the operator configures the organization secret and its Dependabot copy, then the callers merge into staging and reach main. No deployment is part of this PR.