Skip to content

Remove the fail_after note from AGENTS.md - #3727

Closed
Kludex wants to merge 1 commit into
mainfrom
remove-fail-after-note
Closed

Kludex wants to merge 1 commit into
mainfrom
remove-fail-after-note

Conversation

@Kludex

@Kludex Kludex commented Oct 17, 2026

Copy link
Copy Markdown
Member

Drops the AGENTS.md rule that told agents to wrap every indefinite wait in anyio.fail_after(5). In in-memory tests it mostly adds nesting without catching anything.

AI Disclaimer

This PR was developed with the assistance of either Claude or Codex. I've reviewed and verified the changes.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-17T13:47:33.577901Z 15bc141 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Turn on auto-fix | Re-trigger cubic

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review found no issues

No high-confidence issues detected in this change.

@Kludex

Kludex commented Oct 17, 2026

Copy link
Copy Markdown
Member Author

Closing: the rule only targets event.wait() / stream.receive(), which is reasonable. It was misapplied in #3726, not wrong.

@Kludex Kludex closed this Oct 17, 2026
@Kludex
Kludex deleted the remove-fail-after-note branch October 17, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant