Repository navigation
Conversation
Signed-off-by: LauraGPT <18321252+LauraGPT@users.noreply.github.com>
Signed-off-by: LauraGPT <18321252+LauraGPT@users.noreply.github.com>
LauraGPT
left a comment
There was a problem hiding this comment.
Substantive review of exact head 1efefd70d3b770d40f38448e11f8acca8a747da0:
I inspected all eight changed files. The version contract and candidate links
agree on 1.4.17; all four README news sections preserve the existing three-item
contract and published 1.4.16 information. The two repository-role guides do not
falsely announce publication. I found no additional blocking defect in this
eight-file candidate diff.
Release-readiness findings: the PR body still described the superseded first
head and its build artifacts, so it has been reconciled to the current head and
the actual validation scope. Main now includes #3772 and #3774; exact final-tree
validation and final-tag artifact verification remain required. Historical
first-head wheel/sdist hashes must not be used as current-head or final-release
acceptance. No new full-suite, GPU or artifact validation is claimed here.
This is an agent-assisted COMMENT review from the author account, not an
independent approval. The actual required approval is still absent. I have not
self-approved, bypassed protection, changed branch policy or published 1.4.17.
Summary
Prepare FunASR 1.4.17. This PR changes eight files only: the package version,
the release-version contract, four README news entries and two repository-role
guides. The documentation explicitly distinguishes the unpublished 1.4.17
candidate from published 1.4.16. No model or runtime implementation changes
are introduced by this PR.
The candidate started from
e7e61293d308f4342ab9307895e710e4b51b949c.Main has since advanced to
28a889cba5a00333dfb2dee115bd1cfab51f25e1, including#3772 (independent automatic batch keys) and #3774 (UTF-8 dataset-list I/O).
These main-only changes are not covered by the old candidate validation below.
The actual final merged/tagged tree must be validated before publication.
Exact Candidate Validation
1efefd70d3b770d40f38448e11f8acca8a747da0.4374e90d9b49f330ee82c5d5319d5b49552994aa.The appended fix preserves all three items and both release-status statements;
the contract itself was not weakened.
skipped, 22 subtests passed. Two rendering cases were deselected locally.
This is not the complete repository suite or GPU/model validation.
including build-and-validate and browser. Unchanged terminal CI was not rerun
for this documentation reconciliation.
241c1efb4dfa36139ef82b28ca6ee900d892c280. They are historical evidence only,not validated artifacts for the current head or final release tag.
October 16 Current Integration Preflight
The current synthetic merge
b84975986ab2a08d722c88e30eb5cb0cff4d0a25combines main
28a889cba5a00333dfb2dee115bd1cfab51f25e1and this PR's exacthead
1efefd70d3b770d40f38448e11f8acca8a747da0; its tree is34d832415b4714d2f8c0a528ed0ffbfd89fee89d. This does not merge the PR.Fourteen related CPU/unit/documentation/package test files: 214 passed,
1 optional Sphinx check skipped, 30 subtests passed. The suite emitted
75 warnings, primarily existing NumPy copy-argument and deprecated audio-module
warnings. All 4,151 source blobs were verified unchanged before and after.
Offline PEP 517 wheel and sdist builds and Twine metadata checks passed on
that integration tree. Required runtime package files match source bytes.
All ten
runtime-llamacpp-v0.2.6archives, including CUDA Blackwell, werechecked from existing cached bytes against the current release's SHA-256
digests and sizes. Archive integrity was checked; platform binaries were not
executed. No model weights were downloaded.
Wheel SHA-256:
83953731ac6e0c219f5cbe591f05b5af5d2f922992c0946faf88fec8a8498931.Normalized sdist SHA-256:
1f2bb05fc0e0a68891bdd6e965339a4c6c68b5267cc787b09c406be9844f0932.The candidate checksum manifest covers the ten runtime archives and two
Python packages; its SHA-256 is
ff02a9f2bc72d946602514533ce83e4ad2debfaa58ac4f1220042139122b2f37.The built candidate wheel was then installed offline into an isolated target
and exercised on an actual NVIDIA H100 using existing cached SenseVoiceSmall,
FSMN-VAD and punctuation weights. All three modules executed CUDA operations
(2,256 ASR, 60 VAD and 686 punctuation Linear calls).
The existing 80.589-second public recording produced exactly matching text,
sentence information, timestamps and words. Three distinct unkeyed audio slices
also produced three unique automatic keys. They were processed with supported
VAD batch_size=1; this is not a claim of tensor batch size three.
The first GPU check failed when its test harness passed batch_size=3 to
FSMN-VAD, which explicitly requires one. That failed receipt is retained.
Correcting only the harness call gave exit 0 in 40.36 seconds; no repository
implementation or expected output was changed to obtain the pass.
These are integration-preflight artifacts, not final merged/tagged artifacts,
the complete test suite, other-platform runtime validation, or a fresh hosted CI result.
Nothing has been uploaded or published by this preflight. Rebuild and verify
the actual final tag and uploaded bytes before PyPI publication. An initial
review request has been sent to repository administrator @pengzhendong; the
required genuine independent approval is not replaced by the author review.
Review And Publication State
An agent-assisted substantive review inspected all eight changed paths and the
new main-only delta. This is a COMMENT review by the PR-author account, not an
independent APPROVE, and does not satisfy the required approving review.
The observed main protection still requires one approving review and enables
Code Owner review. No approval is fabricated, no administrator bypass is used,
and protection is not changed. Repository auto-merge is disabled.
As of the October 16 review, this PR is open and unmerged. Published GitHub and
PyPI version 1.4.16 already exists; 1.4.17 has not been tagged or published.
The existing pre-release backup and original audit artifacts remain preserved.
Before release: resolve the real review gate, lease exact head/main and discussion
state, validate the actual merge/tag tree, build and inspect its real wheel/sdist
bytes, reconcile release assets and verify the final manifest. The current
runtime contract is
runtime-llamacpp-v0.2.6with ten archives including CUDABlackwell: thirteen final assets including wheel, sdist and checksum manifest.
The current contract must be rechecked at publication; do not substitute stale
artifact hashes or omit a runtime. PyPI remains the final publishing step.