Repository navigation
docs: note telemetry cost and OTel sampling env vars - #108
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a "Telemetry cost" section to AGENTS.md next to pool and server sizing.
The numbers come from litestar-sqlalchemy-template, which wires OTel and Sentry through lite-bootstrap the same way; the section says this template was not measured. On that template with one Granian worker, OTel and Sentry each added about 0.3 ms of CPU per request and together cut read throughput by about 40%. Sampling 10% with
parentbased_traceidratioremoved about half of OTel's cost, since the ASGI middleware and SQLAlchemy hooks still run on unsampled requests.The Sentry finding is left out here, because it came from Sentry's Litestar integration and this template uses the Starlette and FastAPI ones.
No code change: the SDK already reads
OTEL_TRACES_SAMPLERandOTEL_TRACES_SAMPLER_ARG, because lite-bootstrap passes no sampler.