Repository navigation
Soften the dark theme and widen the issues column - #44
Merged
Merged
Conversation
Idle services and out-of-scope rows keep readable text instead of fading with opacity, and the issues column grows with the window.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dark mode was hard to read, and the issues column stayed at 420px however wide the window was.
Dark theme
opacity, which left their text at 1.7 to 3.4:1. They are still clickable, so they need 4.5:1. They now use a new--faintcolor (5.9:1 in dark, 4.6:1 in light), and an idle service gets a dashed border to mark it.#0d1117to grey#22272e, close to GitHub's Dark Dimmed. Body text drops from 16:1 to 10:1, so thin text no longer glows, and the accents are lighter and less saturated, as Material's dark theme guidance suggests.--pill-bg,--pill-fg). Light mode keeps solid pills because a tint there falls to 3.9:1.Issues column
The column is
clamp(420px, 32vw, 640px)instead of a fixed420px, andmaingoes frommax-width: 1680pxto2048px. At 1440px the column is 460px; at 1920px it is 614px.Tests
test_demo_an_idle_service_keeps_readable_text(light and dark) computes the contrast of the idle service's text with opacity included, andtest_demo_the_side_column_grows_with_a_wide_windowchecks the column width at 1920px. Both failed before the change.just test-smoke,just test-ciandjust lint-cipass.The demo has no out-of-scope rows, so that change was checked only by reading the CSS.