Skip to content

feat: Comprehensive File Viewer overhaul - #7805

Open
Dragon-Seeker wants to merge 20 commits into
mainfrom
blodhgarm/file-tabs-rework
Open

Dragon-Seeker wants to merge 20 commits into
mainfrom
blodhgarm/file-tabs-rework

Conversation

@Dragon-Seeker

@Dragon-Seeker Dragon-Seeker commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

General idea behind is to use the given components and layout for viewing any filesystem (Local, Server, Archives) and at the same time overhaul such based on Github style of content viewing or any file manager.

  • Tabs:
    • Viewing the following file types:
      • Folders [Done]
      • Text files [Done]
      • Image files
      • Media files (Audio/Video) (Future PR)
    • Persistence based on workspace i.e. server or such
  • Sidebar:
    • Tree view of the entire directory tree
    • Persistence of width across all instances of the file viewer?
  • Search:
    • Searching within the sidebar is global i.e. searching beyond current selected folder/file
    • When inside a folder, right search button can be used to look for files in directory?
    • When inside a file, right search button can be used to look for files in file
  • Nav bar:
    • Integrate Home within the breadcrumbs instead of being a button on the side
    • History tracker useful to go backwards or forwards though past set of navigations
  • Adjustable Side Padding: Left and right padding can be toggled on or off if space is available
  • Customizable Table: Adjust table columns to what ever you want i.e. show all 4 columns or only show Size
  • Collapsible Footer: To keep the view within your scroll view, footer needs to be collapsed and can be opened either by pullout tab button at the bottom or scrolling
  • Details Tooltip: Hover tooltip contain extra information that can be hovered to select quick info from a specific file

Styling

  • Colored Icons: Color based on some known types and make folders amber for contrast
  • More Icons: Add more default icons for logs, crashreports, and screenshots

- Use DockView for split pane of the sidebar and main file/folder browser
- Start work on sidebar folder browser and the needed layout changes
- Add ability to toggle expanded view for file browser to instead of being within centered column, adjust it to take all the width possible.
- Add ability to make modals into pullout containers
- Fix issues with small resolutions allowing for the background elements to be scrolled leading to double scrolling with modal.
- Resolve minor sizing bug that lead to gap at the bottom or clipping of bottom element on odd scaling and resolutions.
…d layout for sidebar and browser

Mainly done due to issues with DockView requiring set dimensions to layout elements and such not really being possible for concept of how virtual scroll container and sticky sidebar works.

- Fix issues with not being able to select files/folders not in active directory view
- Implement lazy directory handling for server panel
- Make footer for files tab collapsible either with a needed about of scrolling access or a pull tab button to make it appear
- Adjust the tooltip hover to be a wait for either hover or unhover to control when a tooltip will appear or disappear
- Remove shift show from file entry details tooltip
- Add new file actions to sidebar tree entries by abstracting the options out of file actionbar
- Remove bottom padding for files tab, add outlines for tab bar, fix top bar sizing inconsistencies when viewing file or folder
- Make refresh show the loading bar to indicate refresh state
- Refactor FileManagerContext to deduplicate methods and use FileInfo where possible
@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

Pull request changelog

App

Added

Changed

Deprecated

Removed

Fixed

Security

Website

Added

Changed

Deprecated

Removed

Fixed

Security

Hosting

Added

Changed

Deprecated

Removed

Fixed

Security

@Dragon-Seeker
Dragon-Seeker force-pushed the blodhgarm/file-tabs-rework branch from 731568c to 261ae2f Compare October 4, 2026 03:09
@github-actions

github-actions Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Frontend previews

Last deployed commit is e5471b57c3c1881c40776797451f493dc27a4a2a

Persistent

Environment URL
staging https://pr-7805.frontend-staging.rinth.dev
production https://pr-7805.frontend.rinth.dev
storybook https://pr-7805-storybook.modrinth.workers.dev

Latest commit

Environment URL
staging https://198e28e8.frontend-staging.rinth.dev
production https://880965cf.frontend.rinth.dev

…elay length, and hoverability

Overall refactor tooltip handling to reduce duplicate implementation details
…rmance issues

- Adjust context for file manager and UI extend the base context rather than needing to inject two context
- Add toggle between simple and advance mode within table settings
- Adjust details tooltip to only show info not present within the table row view
- Fix issue where tabs would not adjust for the changes like moving or renaming of files/folders
- Start work on integrating changes within APP
…ced File Searching

- Add close tab actions when right clicking tab
- Add ablity to right click nav bar breadcrumbs to act on given file item
- Resolve issues with tabs clipping when too many exist
- Resolve issues where sidebar search would disappear when looking at a file
- Add Action/Details API to add more actions for files
- Add dropdown file search for looking at files rather than filtering sidebar view
@Dragon-Seeker
Dragon-Seeker marked this pull request as ready for review October 7, 2026 01:07
@tdgao
tdgao self-requested a review October 17, 2026 18:33
@Dragon-Seeker
Dragon-Seeker added this pull request to stack #8046 October 20, 2026 05:31

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant