Repository navigation
fix: match fixed capacity to the allocated storage - #18
Open
feritcemkahraman wants to merge 1 commit into
Open
feritcemkahraman wants to merge 1 commit into
feritcemkahraman wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fixed queue created with capacity
1.5allocates one slot, but keeps1.5as its capacity. After the first push, the overflow check never matches; another push can lose the queued item. A capacity of0.5similarly allocates no storage yet accepts a push.Use the allocated ID array length as the fixed capacity, matching the typed array constructor's length conversion. Dynamic queues keep their infinite capacity.
Validation: both new regression tests failed before the fix.
npm testpasses ESLint, TypeScript declaration generation and all 7 tests afterward (Node 24).git diff --checkpasses.