Skip to content

Remove native version and use native contract hash - #425

Merged
josesimoes merged 1 commit into
developfrom
new-assembly-format
Oct 12, 2026
Merged

josesimoes merged 1 commit into
developfrom
new-assembly-format

Conversation

@josesimoes

Copy link
Copy Markdown
Member

Description

  • The AssemblyNativeVersion attribute is removed from the assembly info.
  • The nuspec description now states the native contract hash required from the target, instead of the native version and checksum.
  • The nuspec tags now include the nfnc- native contract hash tag.
  • The nanoFramework.CoreLibrary dependency is updated to 2.0.0-preview.63 in the nuspec, packages.config, nfproj and packages.lock.json files.

Motivation and Context

How Has This Been Tested?

Built by the CI pipeline of this PR.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

🤖 Generated with Claude Code

- Remove AssemblyNativeVersion attribute from AssemblyInfo.
- Update nuspec description and tags to use the native contract hash.
- Update nanoFramework.CoreLibrary to 2.0.0-preview.63 in nuspec, packages.config, nfproj and lock files.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@nfbot nfbot added the Type: dependencies Pull requests that update a dependency file label Oct 12, 2026
@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: nanoframework/coderabbit/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: dded44a8-b3c3-49f2-a164-d5ddb364ac9a

📥 Commits

Reviewing files that changed from the base of the PR and between 651f7d9 and d5044a1.


📒 Files selected for processing (20)
  • Tests/IPAddressTests/IPAddressTests.nfproj
  • Tests/IPAddressTests/packages.config
  • Tests/IPAddressTests/packages.lock.json
  • Tests/NetworkHelperTests/NetworkHelperTests.nfproj
  • Tests/NetworkHelperTests/packages.config
  • Tests/NetworkHelperTests/packages.lock.json
  • Tests/SocketTests/SocketTests.nfproj
  • Tests/SocketTests/packages.config
  • Tests/SocketTests/packages.lock.json
  • Tests/SslStreamTests/SslStreamTests.nfproj
  • Tests/SslStreamTests/packages.config
  • Tests/SslStreamTests/packages.lock.json
  • Tests/SslStreamTests_WiFi/SslStreamTests_WiFi.nfproj
  • Tests/SslStreamTests_WiFi/packages.config
  • Tests/SslStreamTests_WiFi/packages.lock.json
  • nanoFramework.System.Net.nuspec
  • nanoFramework.System.Net/Properties/AssemblyInfo.cs
  • nanoFramework.System.Net/System.Net.nfproj
  • nanoFramework.System.Net/packages.config
  • nanoFramework.System.Net/packages.lock.json

💤 Files with no reviewable changes (1)
  • nanoFramework.System.Net/Properties/AssemblyInfo.cs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.



📝 Summary

Summary by CodeRabbit

  • Compatibility
    • Updated the networking package’s runtime compatibility requirement to include the System.Net native contract. Targets must provide this contract to use the package.
    • Aligned the package and its related test projects with nanoFramework Core Library preview 63.

Walkthrough

System.Net and five test projects now use nanoFramework.CoreLibrary preview 63 instead of preview 52. The System.Net package metadata now identifies its native contract hash, and the assembly native version attribute was removed.

Changes

CoreLibrary and package metadata update

Layer / File(s) Summary
System.Net package metadata and dependency
nanoFramework.System.Net.nuspec, nanoFramework.System.Net/Properties/AssemblyInfo.cs, nanoFramework.System.Net/System.Net.nfproj, nanoFramework.System.Net/packages.*
The package metadata now identifies the System.Net native contract hash. The assembly native version attribute was removed. The project and package records now use CoreLibrary preview 63.
Test project dependencies
Tests/IPAddressTests/*, Tests/NetworkHelperTests/*, Tests/SocketTests/*, Tests/SslStreamTests/*, Tests/SslStreamTests_WiFi/*
The test project references and package records now use CoreLibrary preview 63, with updated lockfile hashes.

Priority: ⬆️ High

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested labels: Area: Config-and-Build

Suggested reviewers: nfbot


Merge Risk: ⚪ Minimal · up to d5044

This change updates the CoreLibrary dependency consistently and switches the package metadata to the System.Net native contract hash. Before the package is released, the nf-interpreter native declaration must be updated to the new hash (0x5AD7808D), as noted in the project's tracking issue. That release prerequisite is outside this repository. No code-level merge blocker was found.

Pre-merge checks · Passed 4
Passed Passed checks (4 passed)
Check name Status Explanation
Description check Passed The description clearly covers removal of AssemblyNativeVersion, native contract hash updates, and the CoreLibrary dependency update.
Title check Passed The title is concise, descriptive, directly related to the main changes, and does not end with a full stop.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nfbot

nfbot commented Oct 12, 2026

Copy link
Copy Markdown
Member

⚠️ Native declaration update required!

The native contract hash of nanoFramework.System.Net has changed. The native declaration in nf-interpreter must be updated before this package can be released.

Previously published This build
Native contract hash 0x0D0C3837 0x5AD7808D

👉 Tracking issue: nanoframework/Home#1916

The issue contains a link to the stubs artifact from this build and instructions for GitHub Copilot to perform the update.

@josesimoes

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@josesimoes
josesimoes merged commit 5f4ade9 into develop Oct 12, 2026
7 of 8 checks passed
@josesimoes
josesimoes deleted the new-assembly-format branch October 12, 2026 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants