Repository navigation
fix: Servers says why a machine cannot be listed, and offers a terminal only when ssh wanted a prompt - #171
Merged
Merged
Conversation
…al only when ssh wanted a prompt - A machine whose entry nerd will not use (a host starting with '-', a bad name) offers no List servers, and its details say why and where to fix it, instead of promising a listing over ssh. - The Can't reach window, with its terminal or copied command, comes only when ssh refused a password or host key prompt under BatchMode. Any other failure, such as a host that does not resolve, shows in the machine's section, and its details hold the whole message. Part of #6 Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found walking group A of #6 (
nerd --remoteand Servers..., no ssh):remotesentry nerd will not use (a host starting with-, a bad name) offered "list servers", and its details promised a listing over ssh. It now offers nothing, and its details say why and where to fix it.nerd --remote) came on every ssh failure, such as a host that does not resolve, where a terminal fails the same way. It now comes only when ssh refused a password or host key prompt under BatchMode (Permission denied (…)orHost key verification failed). Any other failure shows in the machine's section, and the machine's details hold the whole message, which the row cuts to the window's width.ssh_failed, as a field of the client's message to the server; only the client decides it.Tests: a refused prompt in the fake ssh, the details of an unusable machine and of a failed one; each fails on the old code.
Part of #6
🤖 Generated with Claude Code