Skip to content

refactor(file-actions): unify - #17864

Merged
alperozturk96 merged 4 commits into
masterfrom
refactor/unify-file-actions
Oct 22, 2026
Merged

alperozturk96 merged 4 commits into
masterfrom
refactor/unify-file-actions

Conversation

@alperozturk96

Copy link
Copy Markdown
Collaborator

Issue

In the application, we have many places where the same file actions are triggered, resulting in duplicated code. Sometimes, we also forget to include or exclude certain actions. Centralizing these actions would help reduce code duplication and ensure consistency across the application.

Changes

  • Unifies actions for FileDetailsFragment and OCFileListFragment

How to test?

  1. Test file/folder actions from file list
  2. Test file/folder actions from media tab
  3. Test file/folder actions from details

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 added 3. to review ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Oct 22, 2026
@alperozturk96 alperozturk96 added this to the Nextcloud App 35.1.0 milestone Oct 22, 2026
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice2424
Correctness5151
Dodgy code159158
Experimental11
Malicious code vulnerability11
Multithreaded correctness2020
Performance2828
Security1515
Total299298

@github-actions

Copy link
Copy Markdown

📱 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 6e49655
Version 17864
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@codecov

codecov Bot commented Oct 22, 2026

Copy link
Copy Markdown

@alperozturk96
alperozturk96 merged commit c4932a7 into master Oct 22, 2026
25 checks passed
@alperozturk96
alperozturk96 deleted the refactor/unify-file-actions branch October 22, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants