Repository navigation
nirfsa add enable/disable calibration plane new deembedding functions. - #2242
Draft
mohit-emerson wants to merge 6 commits into
Draft
mohit-emerson wants to merge 6 commits into
mohit-emerson wants to merge 6 commits into
Conversation
mohit-emerson
requested review from
marcoskirsch,
ni-jfitzger and
vnktshr21
as code owners
October 26, 2026 08:37
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2242 +/- ##
==========================================
- Coverage 88.12% 83.86% -4.26%
==========================================
Files 88 78 -10
Lines 22830 18747 -4083
==========================================
- Hits 20118 15723 -4395
- Misses 2712 3024 +312
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vnktshr21
reviewed
Oct 26, 2026
| rfsa_device_session.create_deembedding_sparameter_table_array('', 'myTable2', frequencies, sparameter_tables, nirfsa.SparameterOrientation.PORT2_TOWARDS_DUT) | ||
| rfsa_device_session.delete_all_deembedding_tables() | ||
|
|
||
| def test_deembedding_compensation_gain_changes_with_enabled_calibration_planes(self, rfsa_device_session): |
Collaborator
There was a problem hiding this comment.
this test is just ensuring that the python api is functional. lets just name it as test enable and disable caplanes
mohit-emerson
marked this pull request as draft
October 26, 2026 10:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
enable_calibration_plane&disable_calibration_planedeembedding functionscalplanesrepeated capability support fordeembedding_selected_tableattribute.List issues fixed by this Pull Request below, if any.
None
What testing has been done?
PR Validations