Skip to content

refactor: replace semver with verkit - #1168

Open
btea wants to merge 1 commit into
nodejs:mainfrom
btea:refactor/replace-semver-with-verkit
Open

btea wants to merge 1 commit into
nodejs:mainfrom
btea:refactor/replace-semver-with-verkit

Conversation

@btea

@btea btea commented Oct 18, 2026

Copy link
Copy Markdown
Contributor

Description

refer to https://e18e.dev/docs/replacements/semver

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run node --run test and all tests passed.
  • I have check code formatting with node --run format:check & node --run lint.
  • I've covered new added functionality with unit tests if necessary.

@btea
btea requested a review from a team as a code owner October 18, 2026 07:24
@vercel

vercel Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
api-docs-tooling Ready Ready Preview Oct 18, 2026 7:24am UTC

Request Review

@codecov

codecov Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.11765% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.45%. Comparing base (7238bb1) to head (d8d48ec).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...kages/node-legacy/src/legacy-html-all/generate.mjs 50.00% 1 Missing ⚠️
...cy/src/legacy-html/utils/replaceTemplateValues.mjs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1168      +/-   ##
==========================================
+ Coverage   93.32%   93.45%   +0.12%     
==========================================
  Files         273      278       +5     
  Lines       27050    27823     +773     
  Branches     2722     2789      +67     
==========================================
+ Hits        25244    26001     +757     
- Misses       1784     1800      +16     
  Partials       22       22              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

api-links Generator

Performance estimate (single CI run)

  • Generation time: 58.5% slower (650.00 ms → 1.03 s)
  • Peak memory: 1.9% lower (302.18 MB → 296.58 MB)

json Generator

Performance estimate (single CI run)

  • Generation time: 25.8% slower (7.48 s → 9.41 s)
  • Peak memory: 6.3% lower (1.21 GB → 1.13 GB)

legacy-html Generator

Performance estimate (single CI run)

  • Generation time: 45.0% slower (14.67 s → 21.27 s)
  • Peak memory: 0.0% higher (1.84 GB → 1.84 GB)

legacy-json Generator

Performance estimate (single CI run)

  • Generation time: 1.2% faster (5.82 s → 5.75 s)
  • Peak memory: 4.3% lower (1.26 GB → 1.21 GB)

llms-txt Generator

Performance estimate (single CI run)

  • Generation time: 1.1% slower (7.57 s → 7.65 s)
  • Peak memory: 2.3% higher (1.14 GB → 1.17 GB)

orama-db Generator

Output size: 1 file changed · net -121.00 B

File size details
File Main PR Change
orama-db.json 29.15 MB 29.15 MB -121.00 B (-0.0%)

Performance estimate (single CI run)

  • Generation time: 49.0% slower (5.65 s → 8.42 s)
  • Peak memory: 6.0% lower (1.33 GB → 1.25 GB)

web Generator

Output size: 64 files changed · net +1.86 KB

File size details
File Main PR Change
assets/SearchBox-DjNnuz7W.js 84.67 KB — -84.67 KB (-100.0%)
assets/SearchBox-CnfNSood.js — 84.67 KB +84.67 KB
assets/dist-DruvUqXN.js 30.42 KB — -30.42 KB (-100.0%)
assets/dist-D1K_8j5P.js — 30.42 KB +30.42 KB
assets/SideBar-BrLPR3r1.js — 27.58 KB +27.58 KB
assets/SideBar-DaKBoTPQ.js 25.62 KB — -25.62 KB (-100.0%)
assets/client-DxC3O6Ca.js 24.91 KB — -24.91 KB (-100.0%)
assets/client-CavbA88Z.js — 24.91 KB +24.91 KB
assets/config-DtT2jlD0.js 24.09 KB — -24.09 KB (-100.0%)
assets/config-vsHsYbMc.js — 24.00 KB +24.00 KB
assets/Combination-d5oRXla-.js 16.11 KB — -16.11 KB (-100.0%)
assets/Combination-BZfY02Kl.js — 16.11 KB +16.11 KB
assets/ThemeToggle-DVZdvZ7l.js 13.65 KB — -13.65 KB (-100.0%)
assets/ThemeToggle-DUv9PYsw.js — 13.65 KB +13.65 KB
assets/dist-DVEbYasF.js 10.20 KB — -10.20 KB (-100.0%)
assets/dist-RazYUixH.js — 10.20 KB +10.20 KB
assets/Layout-C5yPmBoc.js 10.13 KB — -10.13 KB (-100.0%)
assets/Layout-19Xw3tcX.js — 10.13 KB +10.13 KB
assets/compat-ByVaDh64.js 10.13 KB — -10.13 KB (-100.0%)
assets/compat-TcYw20cx.js — 10.13 KB +10.13 KB
assets/Tooltip-C41LEB8U.js 7.93 KB — -7.93 KB (-100.0%)
assets/Tooltip-SQ4rcdzA.js — 7.93 KB +7.93 KB
assets/dist-DNbUuC3x.js 6.99 KB — -6.99 KB (-100.0%)
assets/dist-C9PSoZSe.js — 6.99 KB +6.99 KB
assets/jsx-runtime-CW012A50.js 5.67 KB — -5.67 KB (-100.0%)
assets/jsx-runtime-hnkVC3PL.js — 5.67 KB +5.67 KB
assets/dist-cDFsq_2f.js 3.93 KB — -3.93 KB (-100.0%)
assets/dist-DFKfOMY4.js — 3.93 KB +3.93 KB
assets/CodeTabs-DT17uorw.js 3.89 KB — -3.89 KB (-100.0%)
assets/CodeTabs-BgG-Xi0r.js — 3.89 KB +3.89 KB
assets/CodeBox-BNILFdqT.js 3.44 KB — -3.44 KB (-100.0%)
assets/CodeBox-DE-QBfyk.js — 3.44 KB +3.44 KB
assets/hooks.module-BbOQEtt2.js 3.40 KB — -3.40 KB (-100.0%)
assets/hooks.module-BKBoXain.js — 3.40 KB +3.40 KB
assets/FunctionSignature-BQoQjJ6P.js 2.28 KB — -2.28 KB (-100.0%)
assets/FunctionSignature-BRFAsE4c.js — 2.28 KB +2.28 KB
assets/Banner-Zf4myBWm.js 2.13 KB — -2.13 KB (-100.0%)
assets/Banner-BZ2eT58M.js — 2.13 KB +2.13 KB
assets/ChangeHistory-C3DUcRCX.js 1.77 KB — -1.77 KB (-100.0%)
assets/ChangeHistory-CpRHXAwv.js — 1.77 KB +1.77 KB
assets/DataTag-CTUSGgLj.js 856.00 B — -856.00 B (-100.0%)
assets/DataTag-Cvobt4Va.js — 856.00 B +856.00 B
assets/DocumentationIndex-D_jFywVL.js 833.00 B — -833.00 B (-100.0%)
assets/DocumentationIndex-DWk1ptrO.js — 833.00 B +833.00 B
assets/ArrowUpRightIcon-BSpTwAaB.js 618.00 B — -618.00 B (-100.0%)
assets/ArrowUpRightIcon-Bod6_6qQ.js — 618.00 B +618.00 B
assets/Badge-CZF-RiB7.js 616.00 B — -616.00 B (-100.0%)
assets/Badge-CEU-XN7s.js — 616.00 B +616.00 B
assets/AlertBox-BNnsWt2b.js 591.00 B — -591.00 B (-100.0%)
assets/AlertBox-D4aUZn7_.js — 591.00 B +591.00 B
assets/CodeBracketIcon-TvXI-m3T.js 512.00 B — -512.00 B (-100.0%)
assets/CodeBracketIcon-BdnL6gfx.js — 512.00 B +512.00 B
assets/dist-D1kGHM6c.js 477.00 B — -477.00 B (-100.0%)
assets/dist-Cxb8owmt.js — 477.00 B +477.00 B
assets/ChevronDownIcon-BOnMJQ3A.js 468.00 B — -468.00 B (-100.0%)
assets/ChevronDownIcon-CblfD9Ke.js — 468.00 B +468.00 B
assets/renderLabel-CdEZo9LC.js 447.00 B — -447.00 B (-100.0%)
assets/renderLabel-B0D0bspV.js — 447.00 B +447.00 B
assets/Blockquote-C7yOM0SI.js 167.00 B — -167.00 B (-100.0%)
assets/Blockquote-DTNJcM3-.js — 167.00 B +167.00 B
assets/useRemoteConfig-DRPTLZY3.js 151.00 B — -151.00 B (-100.0%)
assets/useRemoteConfig-CWY6Vydd.js — 151.00 B +151.00 B
assets/withIsland-C7ctRfG5.js 105.00 B — -105.00 B (-100.0%)
assets/withIsland-BUPR5-bm.js — 105.00 B +105.00 B

Performance estimate (single CI run)

  • Generation time: 0.8% faster (24.88 s → 24.69 s)
  • Peak memory: 0.4% lower (2.04 GB → 2.03 GB)

@avivkeller

Copy link
Copy Markdown
Member

@btea rebase?

@bmuenzenmeyer

bmuenzenmeyer commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

how does everyone else feel about these getting slower but potentially smaller? #1168 (comment)

i've been thinking a lot about what it means to adopt new tools.
edit: I don't like that this doesn't follow semver, nor a security policy

@MattIPv4

Copy link
Copy Markdown
Member

My not very strongly held $0.02 is that we maybe should have a slight bias towards reduing memory usage over improving speed, given the constraints we've seen when generating the Node.js API docs?

@ovflowd

ovflowd commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

These could be flaky results tho

@bmuenzenmeyer bmuenzenmeyer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am a hard block on this

I don't like that this doesn't follow semver, nor has a security policy.

i'd much much much rather us retain more feature-complete libraries that have more eyes on them than this. i dont always fall on that side of the coin (see #1118 (review)) - but this doesnt feel like the same caliber project IMO

This branch was successfully deployed

1 active deployment
Preview – api-docs-tooling — d8d48ece Deployed Oct 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants