Skip to content

fix(update-v8): resolve temporal_capi deps in vendored sources - #1230

Merged
legendecas merged 1 commit into
nodejs:mainfrom
legendecas:main
Oct 27, 2026
Merged

legendecas merged 1 commit into
nodejs:mainfrom
legendecas:main

Conversation

@legendecas

@legendecas legendecas commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

Fixes a resolution failure in node-v8 updater: https://github.com/nodejs/node-v8/actions/runs/40281430436/job/121435377981

https://chromium-review.googlesource.com/c/chromium/src/+/8633019 patched harfrust, making it takes icu_properties 2.4.0.

@codecov

codecov Bot commented Oct 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.86%. Comparing base (31ac767) to head (3eee489).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1230   +/-   ##
=======================================
  Coverage   64.86%   64.86%           
=======================================
  Files          65       65           
  Lines       12334    12334           
=======================================
  Hits         8001     8001           
  Misses       4333     4333           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@legendecas
legendecas merged commit 0120702 into nodejs:main Oct 27, 2026
11 checks passed
@legendecas
legendecas deleted the main branch October 27, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants