Skip to content

lib: enable web worker api by default - #65323

Open
avivkeller wants to merge 1 commit into
nodejs:mainfrom
avivkeller:web-worker-default-enable
Open

avivkeller wants to merge 1 commit into
nodejs:mainfrom
avivkeller:web-worker-default-enable

Conversation

@avivkeller

Copy link
Copy Markdown
Member

cc @panva

Ref: #64894
Ref: #43583

Makes web worker support enabled by default

@avivkeller avivkeller added the semver-major PRs that contain breaking changes and should be released in the next major version. label Aug 16, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/config

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. config Issues and PRs related to Node.js configuration and feature settings. needs-ci PRs that need a full CI run. labels Aug 16, 2026
@codecov

codecov Bot commented Aug 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.49%. Comparing base (c61ba86) to head (cd6e15e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65323      +/-   ##
==========================================
- Coverage   90.50%   90.49%   -0.01%     
==========================================
  Files         797      797              
  Lines      277785   277785              
  Branches    53365    53369       +4     
==========================================
- Hits       251418   251393      -25     
- Misses      16753    16802      +49     
+ Partials     9614     9590      -24     
Files with missing lines Coverage Δ
src/node_options.cc 81.88% <ø> (+0.07%) ⬆️
src/node_options.h 95.23% <100.00%> (-0.44%) ⬇️

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd need to also add the changes entry and update the link at

node/doc/api/globals.md

Lines 1313 to 1320 in 8b9f89f

## Class: `Worker`
<!-- YAML
added: REPLACEME
-->
> Stability: 1 - Experimental. Enable this API with the
> [`--experimental-web-worker`][] CLI flag.

@avivkeller
avivkeller requested a review from aduh95 August 21, 2026 15:59
@panva panva added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label Aug 21, 2026
@panva panva added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Aug 22, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 22, 2026
@nodejs-github-bot

This comment was marked as outdated.

@avivkeller avivkeller added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 23, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 23, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@avivkeller
avivkeller force-pushed the web-worker-default-enable branch from 67ca30a to 1996a2a Compare August 24, 2026 05:11
@avivkeller
avivkeller requested a review from panva August 25, 2026 03:54
@avivkeller

Copy link
Copy Markdown
Member Author

Needs a re-approval

Comment thread doc/api/globals.md Outdated
@aduh95

aduh95 commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

We probably need a regression test

@panva panva removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 7, 2026
Signed-off-by: avivkeller <me@aviv.sh>
@avivkeller
avivkeller force-pushed the web-worker-default-enable branch from 1996a2a to cd6e15e Compare October 17, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash PRs the Commit Queue should land as one squashed commit. config Issues and PRs related to Node.js configuration and feature settings. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants