Skip to content

lib: replace acorn with amaro - #66902

Open
avivkeller wants to merge 1 commit into
nodejs:mainfrom
avivkeller:amaroify
Open

avivkeller wants to merge 1 commit into
nodejs:mainfrom
avivkeller:amaroify

Conversation

@avivkeller

Copy link
Copy Markdown
Member

Replaces the Acorn library with our own Amaro library

Signed-off-by: avivkeller <me@aviv.sh>
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. dependencies PRs that add, update, or configure Node.js dependencies. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. strip-types Issues and PRs related to TypeScript type stripping. labels Oct 21, 2026
@avivkeller
avivkeller marked this pull request as ready for review October 21, 2026 14:56
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/security-wg
  • @nodejs/tsc
  • @nodejs/typescript

@marco-ippolito

Copy link
Copy Markdown
Member

the amaro update should be in a separate commit from the automation

@codecov

codecov Bot commented Oct 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.80519% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.61%. Comparing base (39e03b4) to head (d019a46).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/repl/highlight.js 88.57% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66902      +/-   ##
==========================================
+ Coverage   90.57%   90.61%   +0.03%     
==========================================
  Files         797      797              
  Lines      278502   278094     -408     
  Branches    53540    53483      -57     
==========================================
- Hits       252247   251985     -262     
+ Misses      16592    16438     -154     
- Partials     9663     9671       +8     
Files with missing lines Coverage Δ
lib/internal/errors/error_source.js 74.72% <100.00%> (-7.84%) ⬇️
lib/internal/modules/esm/module_job.js 99.56% <100.00%> (-0.02%) ⬇️
lib/internal/modules/typescript.js 100.00% <100.00%> (ø)
lib/internal/repl/completion.js 91.74% <100.00%> (+0.77%) ⬆️
lib/internal/repl/transform.js 86.04% <100.00%> (+31.97%) ⬆️
lib/internal/repl/utils.js 96.65% <100.00%> (-0.28%) ⬇️
lib/repl.js 95.34% <100.00%> (+2.41%) ⬆️
src/node_builtins.cc 77.31% <ø> (-0.18%) ⬇️
src/node_metadata.cc 92.75% <ø> (-0.11%) ⬇️
lib/internal/repl/highlight.js 95.12% <88.57%> (-2.64%) ⬇️

... and 19 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. dependencies PRs that add, update, or configure Node.js dependencies. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. strip-types Issues and PRs related to TypeScript type stripping.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants