Repository navigation
random-list: fix dice and the error helper on current nushell - #1301
Merged
Merged
Conversation
fdncred
reviewed
Oct 23, 2026
Contributor
There was a problem hiding this comment.
Review overview
🟡 Changes recommended
The std/random import and the span change work on 0.116.2. What's left is argument checks that let 0 through.
Findings: 0
Open (4)
Notes from my clanker, checked on 84629e8 with nu 0.116.2. I ran every random-list subcommand with valid input, 0, negative counts, an out-of-range --bias, and dice counts of 0 and 1.
fdncred
reviewed
Oct 23, 2026
Dice checks now match std's random dice (at least 1 die, at least 2 sides) so the error points at the flag. A count of 0 gives an empty list instead of 2 items, and the error msg no longer has ansi codes in it.
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
random-list dicedidn't parse on current nushell becauserandom dicemoved out of the builtins intostd/random. The module now doesuse std/randomat the top.While testing that I also hit the error helper failing with "missing span column", since
error makewantsspanin the label now instead of separatestartandend. It passes the span through directly so the validation errors show up again.Tested on 0.116.1.
nu --ide-checkis clean, everyrandom-listsubcommand returns what it should, and passing a negative count or a bias above 1 shows the right error pointing at the argument.