Skip to content

bump node to 26.12.1 - #1547

Merged
alexcos20 merged 4 commits into
mainfrom
deps/bump_node_to_26_12_1
Oct 29, 2026
Merged

alexcos20 merged 4 commits into
mainfrom
deps/bump_node_to_26_12_1

Conversation

@alexcos20

@alexcos20 alexcos20 commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Updated the Node.js version used for local development, automated checks, and application containers to 26.12.1. This keeps the runtime consistent across these environments; end-user functionality is unchanged.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 92389bde-4e73-4700-9b67-cb9ff13b6521
Commits

Reviewing files that changed from the base of the PR and between 28bf022 and db6b194.

Files selected for processing: 3
  • .github/workflows/ci.yml
  • .nvmrc
  • Dockerfile

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The configured Node.js version changes from 24.22.1 to 26.12.1 in .nvmrc, CI jobs, and the Docker builder and runner images.

Changes: Node.js version update

Layer / File(s) Summary
Update runtime versions
.nvmrc, .github/workflows/ci.yml, Dockerfile
The .nvmrc file and five CI jobs now use Node.js 26.12.1. The Docker builder and runner images also use Node.js 26.12.1 with a new pinned digest.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Possibly related issues

  • oceanprotocol/ocean-node#1536: The issue requests a Node.js 26.x update, which this pull request makes.

Possibly related PRs

Merge Risk: Minimal · up to db6b1

The Node.js image update is mergeable; required Docker build and runtime dependencies remain available.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the primary change: updating Node.js to version 26.12.1. It does not mention the related Docker image changes, but the title does not need to cover every deta…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title clearly and concisely describes the primary change: updating Node.js to version 26.12.1. It does not mention the related Docker image changes, but the title does not need to cover every detail.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@alexcos20

Copy link
Copy Markdown
Member Author

/run-security-scan

@alexcos20 alexcos20 left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI automated code review (Gemini 3).

Overall risk: low

Summary:
The PR consistently bumps the Node.js version to 26.12.1 across the CI workflows, .nvmrc, and Dockerfile. However, a noticeable regression was introduced in the Dockerfile where the production runner image drops the '-slim' designation. This should be addressed before merging to maintain performance and security best practices.

Comments:
• [WARNING][security] The base image for the runner stage was changed from node:24.22.1-trixie-slim to the full node:26.12.1-trixie image. Moving away from the slim variant for the final production stage significantly increases the final Docker image size and broadens the attack surface by including unnecessary OS packages and development tools.

Suggested fix:

-FROM node:26.12.1-trixie@sha256:31ea2a1880e8393df2445e7654ec74992d7fa450fd659ba5b66b0bec909a55b1 AS runner
+FROM node:26.12.1-trixie-slim@sha256:[update-with-slim-sha256] AS runner

@alexcos20

Copy link
Copy Markdown
Member Author

/run-security-scan

@alexcos20 alexcos20 left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI automated code review (Gemini 3).

Overall risk: low

Summary:
This PR updates the Node.js version from 24.22.1 to 26.12.1 across the CI workflows, .nvmrc, and Dockerfile. The update is consistent across all relevant configuration files. The Docker image SHA256 digests have also been updated to match the new versions. LGTM!

Comments:
• [INFO][performance] The builder image has been switched from node:*-trixie to node:*-trixie-slim. Since python3 and build-essential are explicitly installed on the next line, this is a good change that will reduce the builder image size. Just ensure no implicit dependencies from the full trixie image were being relied upon.

@alexcos20 alexcos20 linked an issue Oct 28, 2026 that may be closed by this pull request
@alexcos20
alexcos20 merged commit 1fdce00 into main Oct 29, 2026
11 checks passed
@alexcos20
alexcos20 deleted the deps/bump_node_to_26_12_1 branch October 29, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump node to 26.x

2 participants