Skip to content

Remove "cdt" package - #12

Open
thomasarsouze wants to merge 19 commits into
masterfrom
11-update-metayml
Open

thomasarsouze wants to merge 19 commits into
masterfrom
11-update-metayml

Conversation

@thomasarsouze

Copy link
Copy Markdown

No description provided.

@thomasarsouze thomasarsouze linked an issue Sep 29, 2026 that may be closed by this pull request
Comment thread conda/meta.yaml Outdated
- make # [unix]
- pkg-config # [linux]
- {{ cdt('mesa-libgl-devel') }} # [linux] # match libqglviewer CDT GL strategy
- mesa-libgl-devel-conda-aarch64 # [linux] # match libqglviewer CDT GL strategy

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should try with libgl-devel based on this

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I get this right.
From description of the package and cdt recommandation, it seems to be the right approach.
However I don't think I'm getting the difference between mesa-libgl-develand libgl-devel because the last one is not the one we're targeting.

Also not sure to understand why build is fine on 2/4 system

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that this package is for aarch64 which is the same thing than arm64 (another architecture we could support) more on those here and there. It's mostly used for android phones or smaller/modern laptops in general.
The {{ cdt('mesa-libgl-devel') }} thing is, from what I understand going to look what your conda install is (from miniforge github):

OS Architecture Minimum Version File
Linux x86_64 (amd64) glibc >= 2.17 Miniforge3-Linux-x86_64.sh
Linux aarch64 (arm64) (**) glibc >= 2.17 Miniforge3-Linux-aarch64.sh
Linux ppc64le (POWER8/9) glibc >= 2.17 Miniforge3-Linux-ppc64le.sh
Linux riscv64 (rv64gc) (***) glibc >= 2.29 Miniforge3-Linux-riscv64.sh

and get the corresponding cdt package (eg. mesa-libgl-devel-conda-ppc64le, mesa-libgl-devel-conda-aarch64, etc...)

Those are still cdt packages. Since we are trying to get rid of them, we should use libgl-devel which from its description is the:

GL Vendor-Neutral Dispatch library

and its supported platforms are:

linux-ppc64le
linux-64
linux-riscv64
linux-aarch64

@AurelienBesnier

AurelienBesnier commented Oct 28, 2026 •

Copy link
Copy Markdown

everything seems to work now, only the macos-latest is not checked rn because the runner seems to be in high-demand

@AurelienBesnier

Copy link
Copy Markdown

I guess everything works now

@thomasarsouze

Copy link
Copy Markdown
Author

Great work !
Not that great to pin an exact version of a dependency. Could we instead pin sip to a minimal version (>=6.10) ? Can you set somewhere why do we need this version ?

Also, in pyproject.toml, we should be consistent and set the same minimal version of sip in the dependencies.

@AurelienBesnier

Copy link
Copy Markdown

the sip version should actually be <=6.10 because more recent version will try to more recent version of the pyqt-sip bindings at runtime. The versions of everything sip is kinda broken on conda, which is why I tried to use pip instead but on the conda build, it wouldn't use pip to install the deps. I don't really know why

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update meta.yml

2 participants