Repository navigation
Conversation
camden-king
reviewed
Oct 30, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #987.
OIDAuthorizationServicesubscripts the parsed token and registration bodies without checking that they're dictionaries, so, a proxy answering with[]borks the app down withNSInvalidArgumentException. This has been there since the first release (#863 was the same crash)!This PR gives the callback an
OIDErrorCodeServerErrorfor a 4xx andOIDErrorCodeJSONDeserializationErrorfor a 2xx whose body isn't an object. The new tests exercise both endpoints through a stubNSURLProtocol.Behaviour change: a 200 with
[]used to yield an emptyOIDTokenResponse. It's an error now :)