Repository navigation
Conversation
Callers that pass customRoles as its own argument must update, so this stays unreleased until the next major. Custom roles alone are sent as the scope string instead of the literal "undefined". Refs #81
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
customRolesis now a property of the options object onAuth.Login,Auth.ElevatedLogin,Auth.ClientCredentials, andAuth.Anonymous, alongsidecancelToken,requestType, and (Anonymous)anonuserid.undefined.14.0.0.package.jsonstays at13.0.0here, and the changelog note stays under Unreleased. The14.0.0release PR is the one that sets the version, moves this note under# [14.0.0], and publishes on merge. Calls that omitcustomRolesare unchanged.Refs #81
Test plan
scope=InventoryAdmin, with noundefinedprefixcustomRolesandanonuseridare absent from the axios config, andrequestTypeis still passed through