Skip to content

#81 - Move auth customRoles onto request options for 14.0.0 - #151

Closed
esitarz wants to merge 1 commit into
masterfrom
fix/81-auth-custom-roles
Closed

esitarz wants to merge 1 commit into
masterfrom
fix/81-auth-custom-roles

Conversation

@esitarz

@esitarz esitarz commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • customRoles is now a property of the options object on Auth.Login, Auth.ElevatedLogin, Auth.ClientCredentials, and Auth.Anonymous, alongside cancelToken, requestType, and (Anonymous) anonuserid.
  • Custom roles with no standard roles are sent as the scope string. That case previously sent the literal text undefined.
  • This ships in 14.0.0. package.json stays at 13.0.0 here, and the changelog note stays under Unreleased. The 14.0.0 release PR is the one that sets the version, moves this note under # [14.0.0], and publishes on merge. Calls that omit customRoles are unchanged.

Refs #81

Test plan

  • Auth tests pass for standard roles, custom roles, both, and neither on all four methods
  • Custom-roles-only token body is scope=InventoryAdmin, with no undefined prefix
  • customRoles and anonuserid are absent from the axios config, and requestType is still passed through

Callers that pass customRoles as its own argument must update, so
this stays unreleased until the next major. Custom roles alone are
sent as the scope string instead of the literal "undefined".

Refs #81
@esitarz esitarz changed the title Move auth customRoles onto request options Move auth customRoles onto request options for 14.0.0 Sep 26, 2026
@esitarz esitarz mentioned this pull request Sep 28, 2026
6 of 7 tasks
@esitarz esitarz linked an issue Sep 28, 2026 that may be closed by this pull request
@esitarz esitarz changed the title Move auth customRoles onto request options for 14.0.0 #81 - Move auth customRoles onto request options for 14.0.0 Sep 28, 2026
@esitarz esitarz closed this Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant