Repository navigation
Conversation
Hoisting every nested xp made OrderWorksheet take 17 parameters. Own xp stays first. Each nested model is now one parameter constrained to that model, so Order<MyOrderXp> still works. Refs #78
esitarz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xpparameters are no longer hoisted onto the parent. A model's ownxpstays the first parameter (Order<MyOrderXp>,Category<MyCategoryXp>). Each nested model that contributedxpparameters is now one parameter constrained to that model (TFromUser extends OrderUser,TLineItem extends LineItem).OrderWorksheetgoes from 17xpparameters to one parameter per nested property.Order<MyOrderXp, MyFromUserXp>andOrderWorksheet<SomeXp>stop compiling.14.0.0. Review it here. It will be merged into the14.0.0branch so that release contains it with the auth break. Merging this pull request tomasterdoes not publish, becausepackage.jsonstays at13.0.0.Refs #78
Test plan
npx tsc -p tests/tsconfig.model-types.jsonpasses, including the@ts-expect-errorcases for the old call shapesOrder,LineItem, andOrderWorksheetsignatures match the migration guideCategoryandProductstay a singlexpparameter