Repository navigation
feat: checks name the solution files they read - #349
Merged
Merged
Conversation
This was referenced Nov 1, 2026
AydinHassan
added a commit
to php-school/phpschool.io
that referenced
this pull request
Nov 1, 2026
Picks up php-school/php-workshop#346 and php-school/php-workshop#349 for php-school/php-workshop#336: each solution runs in one container with its files copied in, and the Redis port lock is released when the sandbox finishes. No website code changes. Tried with real Docker and a throwaway Redis through `CloudInstalledWorkshop` and `LockPortPicker`: learn-you-php Time Server and Database Read pass, no port locks or containers left.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #336, before #346. Replaces #348.
Once the code runs in a container with the files copied in, the files it writes have to come back for the checks that read them. This says which files those are. No behaviour change yet.
Check\ReadsSolutionFilesinterface:getSolutionFiles(ExerciseInterface): list<string>.DatabaseCheckreturns['db.sqlite'],FileComparisonCheckthe exercise's files to compare.ExerciseDispatcher::verify()collects them from the required checks intoExecutionContext::getSolutionFiles().Sandbox::finish(ExecutionContext $context).HostSandboxand today's mountedDockerSandboxhave the files already, so they ignore it.