Repository navigation
Conversation
As we don't care about relative ordering.
Simplifying some logic so that it can be merged in the future
…_key() Simplifying some logic so that it can be merged in the future
…ition Use goto to mimic a continue statement to the outerloop
And refactor it so that it no longer relies on BG(user_compare_fci)
Girgias
force-pushed
the
2026-10-array-cmp-fn-no-global
branch
from
October 20, 2026 17:11
21993bc to
e237ca6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits should be reviewed individually and only merged after #24453 landed.
Seeing #24453 I was wondering if we even needed to use the globals (as IMHO this adds a lot of complexity) and it seems like we don't. I did a few minor refactorings prior to attempting to remove usage of the globals as a lot of the code is effectively identical.