Repository navigation
ext/gd: Fix imagewebp() return value for palette images - #24466
Open
arshidkv12 wants to merge 3 commits into
Open
arshidkv12 wants to merge 3 commits into
arshidkv12 wants to merge 3 commits into
Conversation
ext/gd: Fix imagewebp() return value for palette images ext/gd: Fix imagewebp() return value for palette images ext/gd: Fix imagewebp() return value for palette images
arshidkv12
force-pushed
the
gd-gdImageTrueColor-1
branch
from
October 20, 2026 18:45
e9a7f04 to
51d68c1
Compare
devnexen
reviewed
Oct 20, 2026
| RETURN_FALSE; | ||
| } | ||
|
|
||
| if (!gdImageTrueColor(im)) { |
Member
There was a problem hiding this comment.
as I was about to say in your other PR, your fix is only about the palette case; the report mentioned that libwebp would still report gd-bwep encoding failed and returns true.
Contributor
Author
There was a problem hiding this comment.
Sorry.. I will fix it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#24457