Skip to content

openinstall: re-vendor from sh1pt deploy-ssh 0.1.2 (www -> apex, reload nginx) - #184

Merged
ralyodio merged 1 commit into
masterfrom
openinstall-sync-www
Oct 17, 2026
Merged

ralyodio merged 1 commit into
masterfrom
openinstall-sync-www

Conversation

@ralyodio

Copy link
Copy Markdown
Contributor

Re-vendors templates/openinstall/install.sh from sh1pt's canonical copy (deploy-ssh 0.1.2, profullstack/sh1pt#1035). It's now byte-identical, so openinstall init stops handing out two bugs:

  • www served the app twice: www.<domain> got a full second copy of the site. Now every name after the first in DOMAINS returns 301 to https://<first>.
  • nginx never reloaded: a changed site config was written but nginx kept the old one, because put_root_file ran in a pipeline subshell.

Bumps to 0.68.1. The openinstall tests pass (6/6).

🤖 Generated with Claude Code

…ad nginx)

templates/openinstall/install.sh had both bugs fixed in sh1pt #1035:
www.<domain> served the app a second time (port 80 redirected to
https://$host and both server blocks listed every DOMAINS name), and a
changed nginx site was written but never reloaded (put_root_file ran in a
pipeline subshell, so CHANGED=1 was lost). Now byte-identical to sh1pt's
canonical copy. 0.68.1.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

ThreatCrush Security Scan

33 finding(s)

HIGH/CRITICAL: 7 | MEDIUM: 12 | LOW: 14

Severity Rule Location
HIGH py-ssrf-outbound-request dev2/dev2-site:151
HIGH py-ssrf-outbound-request dev2/dev2-site:1060
HIGH py-ssrf-outbound-request dev2/dev2-site:1775
HIGH sh-remote-script-execution root-ubuntu.sh:3250
HIGH sh-remote-script-execution root-ubuntu.sh:3251
HIGH sh-remote-script-execution root-ubuntu.sh:5146
HIGH sh-remote-script-execution root-ubuntu.sh:5150
MEDIUM sql-template-interpolation dev2/dev2-site:1286
MEDIUM sql-template-interpolation dev2/dev2-site:1363
MEDIUM sh-remote-script-execution root-ubuntu.sh:5354
MEDIUM redos-nested-quantifier src/domain-free.ts:56
MEDIUM redos-nested-quantifier src/emoji.ts:167
MEDIUM redos-nested-quantifier src/icon.ts:166
MEDIUM redos-nested-quantifier src/mail.ts:1047
MEDIUM sql-template-interpolation src/users-dump.ts:487
MEDIUM sql-string-concatenation src/users-dump.ts:507
MEDIUM sql-template-interpolation src/users-dump.ts:540
MEDIUM sql-string-concatenation src/users-dump.ts:574
MEDIUM redos-nested-quantifier src/wcag.ts:556
LOW secret-generic-credential src/credentials.ts:36
LOW secret-generic-credential src/credentials.ts:53
LOW secret-generic-credential src/credentials.ts:56
LOW secret-generic-credential src/credentials.ts:61
LOW secret-generic-credential src/user-export.ts:689
LOW secret-generic-credential src/user-export.ts:695
LOW secret-generic-api-key test/credentials.test.ts:208
LOW secret-generic-credential test/mail.test.ts:141
LOW secret-generic-credential test/proxy.test.ts:69
LOW secret-generic-credential test/proxy.test.ts:85
LOW secret-generic-credential test/shorten.test.ts:36
LOW secret-database-url test/users-dump.test.ts:108
LOW secret-database-url test/users-dump.test.ts:119
LOW secret-database-url test/users-dump.test.ts:120

Snippets are redacted; ThreatCrush never prints matched credential material.

@ralyodio
ralyodio merged commit f4c7e08 into master Oct 17, 2026
5 checks passed
@ralyodio
ralyodio deleted the openinstall-sync-www branch October 17, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant