Skip to content

Link pvlib.iotools in the FAQ entry on irradiance data - #2925

Merged
kandersolar merged 2 commits into
pvlib:mainfrom
mmporong:faq-iotools-link
Oct 28, 2026
Merged

kandersolar merged 2 commits into
pvlib:mainfrom
mmporong:faq-iotools-link

Conversation

@mmporong

@mmporong mmporong commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor
  • Closes #xxxx
  • I am familiar with the contributing guidelines
  • I attest that all AI-generated material has been vetted for accuracy and is in compliance with the pvlib license
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Takes one of the good-first items from the docs tracker #1983: the FAQ entry "Where can I get irradiance data for my simulation?" names "a module called iotools" as plain text. It now links it with :py:mod:pvlib.iotools, the target that reference/iotools.rst defines (.. py:module:: pvlib.iotools) and that weather_data.rst already links the same way. The paragraph is rewrapped; the wording is otherwise unchanged.

A what's new entry is added under Documentation in v0.16.2.

@github-actions

Copy link
Copy Markdown

Hey @mmporong! 🎉

Thanks for opening your first pull request! We appreciate your
contribution. Please ensure you have reviewed and understood the
contributing guidelines.

If AI is used for any portion of this PR, you must vet the content
for technical accuracy.

Finally, be sure the PR description includes the PR
checklist,
and complete the items you are able to.

@echedey-ls

Copy link
Copy Markdown
Member

LGTM, thanks

@echedey-ls echedey-ls added this to the v0.16.2 milestone Oct 28, 2026
@cwhanse

cwhanse commented Oct 28, 2026

Copy link
Copy Markdown
Member

None of the CI errors are caused by the changes in this PR. Wait and we'll kick off the CI again.

@kandersolar
kandersolar merged commit 0f6631a into pvlib:main Oct 28, 2026
1 check passed
mokazemi added a commit to mokazemi/pvlib-python that referenced this pull request Oct 28, 2026
* main:
  Link pvlib.iotools in the FAQ entry on irradiance data (pvlib#2925)
  Address flake8 warnings introduced in pvlib#2924 (pvlib#2926)
  Add pvlib.spa.transit_sunrise_sunset to documentation (pvlib#2873)
  [DEV] address pandas 3.1.0 compatibility issues (pvlib#2924)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants