Skip to content

Address flake8 warnings introduced in #2924 - #2926

Merged
kandersolar merged 22 commits into
pvlib:mainfrom
echedey-ls:dev/breaking-news-pandas3.1
Oct 28, 2026
Merged

kandersolar merged 22 commits into
pvlib:mainfrom
echedey-ls:dev/breaking-news-pandas3.1

Conversation

@echedey-ls

@echedey-ls echedey-ls commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Last patch commit to #2924 that didn't make it in time.

  • [ ] Closes #xxxx
  • I am familiar with the contributing guidelines
  • [ ] I attest that all AI-generated material has been vetted for accuracy and is in compliance with the pvlib license
  • [ ] Tests added
  • [ ] Updates entries in docs/sphinx/source/reference for API changes.
  • [ ] Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • [ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Pandas4Warning: DatetimeIndex.dayofyear is deprecated and will be
removed in a future version. Use DatetimeIndex.day_of_year instead.
…-> DataFrame constructor instead

Pandas4Warning: Passing a list to DataFrame.from_dict is deprecated. Use
the DataFrame constructor instead.
Pandas4Warning: assert_index_equal will check the 'freq' attribute by
default in a future version; these freqs <Minute> and None do not match.
Pass check_freq=True or check_freq=False to silence this warning
    pd.testing.assert_index_equal(left, right, **kwargs)
…GH#71567 is resolved)

pvlib/iotools/tmy.py:226: in read_tmy3
    data_ymd.iloc[-1] = data_ymd.iloc[-1].replace(year=coerce_year+1)
    ^^^^^^^^^^^^^^^^^
venv/lib/python3.14/site-packages/pandas/core/indexing.py:1010: in __setitem__
    iloc._setitem_with_indexer(indexer, value, self.name)
venv/lib/python3.14/site-packages/pandas/core/indexing.py:2653: in _setitem_with_indexer
    self._setitem_single_block(indexer, value, name)
venv/lib/python3.14/site-packages/pandas/core/indexing.py:2985: in _setitem_single_block
    self.obj._mgr = self.obj._mgr.setitem(indexer=indexer, value=value)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
venv/lib/python3.14/site-packages/pandas/core/internals/managers.py:625: in setitem
    return self.apply("setitem", indexer=indexer, value=value)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
venv/lib/python3.14/site-packages/pandas/core/internals/managers.py:456: in apply
    applied = getattr(b, f)(**kwargs)
              ^^^^^^^^^^^^^^^^^^^^^^^
… to pd.DatetimeArray

Pandas4Warning: DatetimeIndex.values returning an ndarray that drops
timezone information is deprecated. In a future version, this will
return the underlying DatetimeArray instead. Use
'DatetimeIndex.tz_convert(None).to_numpy()' to get a NumPy array of UTC
values, or 'DatetimeIndex.array' to get the ExtensionArray.
check_freq is exclusively supported in assert_index_equal, added in
pandas==3.1.0
…mezone information for DatetimeTZDtype is deprecated.

tests/test_solarposition.py::test_sun_rise_set_transit_geometric

/home/echedey/Documents/10_Programming/pvlib-python/tests/test_solarposition.py:835:
Pandas4Warning: Series.values returning an ndarray that drops timezone
information for DatetimeTZDtype is deprecated. In a future version, this
will return the underlying DatetimeArray instead. Use
'Series.dt.tz_convert(None).to_numpy()' to get a NumPy array of UTC
values, or 'Series.array' to get the ExtensionArray.
  See
https://pandas.pydata.org/docs/dev/whatsnew/v3.1.0.html#whatsnew-310-deprecations-values
for more details.
    expected_sunset =
pd.DatetimeIndex(expected_rise_set_spa.sunset.values,
…et object instead of a string from infer_freq

A future version of pandas will return a BaseOffset object instead of a
string from infer_freq. Use
pd.set_option('future.infer_freq_returns_offset', True) to get the
future behavior, or set to False to keep the old behavior and silence
this warning. To preserve the string representation, use
``infer_freq(...).freqstr``.
… default

tests/iotools/test_era5.py::test_get_era5_land

/home/runner/work/pvlib-python/pvlib-python/tests/iotools/test_era5.py:69:
Pandas4Warning: assert_index_equal will check the 'freq' attribute by
default in a future version; these freqs None and <Hour> do not match.
Pass check_freq=True or check_freq=False to silence this warning
    pd.testing.assert_index_equal(df.index, expected.index)

tests/iotools/test_nasa_power.py::test_get_nasa_power

/home/runner/work/pvlib-python/pvlib-python/tests/iotools/test_nasa_power.py:42:
Pandas4Warning: assert_index_equal will check the 'freq' attribute by
default in a future version; these freqs None and <Hour> do not match.
Pass check_freq=True or check_freq=False to silence this warning
    pd.testing.assert_index_equal(data.index, data_index)

tests/iotools/test_nasa_power.py::test_get_nasa_power_pvlib_params_naming

/home/runner/work/pvlib-python/pvlib-python/tests/iotools/test_nasa_power.py:57:
Pandas4Warning: assert_index_equal will check the 'freq' attribute by
default in a future version; these freqs None and <Hour> do not match.
Pass check_freq=True or check_freq=False to silence this warning
    pd.testing.assert_index_equal(data.index, data_index)
@echedey-ls echedey-ls added this to the v0.16.2 milestone Oct 28, 2026
@kandersolar
kandersolar merged commit c317d3a into pvlib:main Oct 28, 2026
29 checks passed
mokazemi added a commit to mokazemi/pvlib-python that referenced this pull request Oct 28, 2026
* main:
  Link pvlib.iotools in the FAQ entry on irradiance data (pvlib#2925)
  Address flake8 warnings introduced in pvlib#2924 (pvlib#2926)
  Add pvlib.spa.transit_sunrise_sunset to documentation (pvlib#2873)
  [DEV] address pandas 3.1.0 compatibility issues (pvlib#2924)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants