Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A rejected
update_settings()call can leave its valid prefix queued even though no SETTINGS frame was emitted. A later acknowledgement then applies an unsent value, contrary to the SETTINGS synchronization described in RFC 9113 section 6.5.3: in a paired client/server reproduction, one side changes its concurrent-stream limit to 3 while the peer still knows 100.I validate the complete batch against the existing rules before queueing any values. This preserves the existing error type, code and message, connection-state error precedence, valid update ordering, and unknown setting codes. The change is limited to
InvalidSettingsValueErrorvalidation failures.Twelve new cases fail before the fix; all 16 regression/control cases pass afterward. The full suite passes 1,678 tests with 100% statement and branch coverage on Python 3.10, 3.12 and 3.13. Ruff, strict-bytes mypy, manifest/package checks, strict distribution checks and the documentation build pass. A fresh installed wheel also passes 12 paired-peer checks outside the checkout. No sockets or external service are needed for these tests.