Repository navigation
Use an explicit generic timezone in instance() tests - #1072
Open
Muguett-DBY wants to merge 1 commit into
Open
Muguett-DBY wants to merge 1 commit into
Muguett-DBY wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_instance_with_aware_datetime_any_tzinfofails with python-dateutil 3.0.0 on unchangedmaster:tz.gettz("Europe/Paris")now supplies an IANAkey, sopendulum.instance()preservesEurope/Paris. The test still expects the generic fallback's+02:00name.Use an explicit
tz.tzoffset("custom", 7200)fixture, which has neitherkeynorlocalize. This keeps the test exercising conversion of a generictzinfoto a fixed offset. The adjacent ZoneInfo test already covers preserving an IANA name. Runtime code and dependency constraints are unchanged.Verified on Windows and Linux, Python 3.12 (validation run):
masterin both pure-Python and Rust-extension modes with dateutil 3.0.0.+02:00assertion is retained.Pull Request Check List
AI-assisted with Codex. Reproduced while independently reviewing #1059; the same unrelated failure is noted in #1069.