Repository navigation
Require ASCII digits in Russian INNs - #543
Open
mjanthony819 wants to merge 2 commits into
Open
mjanthony819 wants to merge 2 commits into
mjanthony819 wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ru_inn()currently accepts non-ASCII decimal digits becauseint()converts them to the same numbers as ASCII digits. For example, translating the existing valid company and individual INN examples into fullwidth or Arabic-Indic digits still returnsTrue.Require an ASCII decimal string before running the existing length and checksum logic. This extends the character-set restriction already applied to Spanish identifiers in #519 and Finnish, French and Indian identifiers in #532. Neither checksum algorithm changes, including the two-check-digit fix in #525.
Ten new regression cases fail before the change and pass afterward. They cover company and individual INNs translated into Arabic-Indic, fullwidth and Devanagari digits, plus single-character substitutions in the first and final positions. The ASCII originals remain accepted.
Validation on Python 3.12:
git diff --checkpasses.AI assistance covered research, implementation, tests and this description.