Repository navigation
gh-69605: fix PyREPL completions inserted for import statements with spaces - #148629
Merged
ambv merged 2 commits intoOct 20, 2026
Merged
Conversation
loic-simon
marked this pull request as ready for review
April 15, 2026 20:34
loic-simon
requested review from
ambv,
lysnikolaou and
pablogsal
as code owners
April 15, 2026 20:34
|
This PR is stale because it has been open for 90 days with no activity. |
edvilme
reviewed
Oct 5, 2026
Comment on lines
+1
to
+2
| Fix :term:`REPL` completions inserted incorrectly when there was spaces in | ||
| import statements. |
Contributor
There was a problem hiding this comment.
Suggested change
| Fix :term:`REPL` completions inserted incorrectly when there was spaces in | |
| import statements. | |
| Fix :term:`REPL` completions inserted incorrectly when there were spaces in | |
| import statements. |
Fix `from math .<tab>` inserting `from math .ath.integer` instead of `from math.integer`
ambv
force-pushed
the
pyrepl-module-completion-fix-space-in-imports
branch
from
October 20, 2026 21:03
799bd64 to
d605a25
Compare
ambv
added
needs backport to 3.14
ambv
approved these changes
Oct 20, 2026
|
Thanks @loic-simon for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
Sorry, @loic-simon and @ambv, I could not cleanly backport this to Please backport manually with cherry_picker, see the devguide for more information. |
|
GH-159989 is a backport of this pull request to the 3.15 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: #148445 (comment)
Turn out the import parser already handled these cases well, the issue was that the REPL only replaces the last entered word when inserting a suggestion, but inserted the whole import dotted name
So I added an additional step in
ModuleCompleter.get_completionsto reduce the completions to the portion to insert onlycc @tomasr8