Repository navigation
gh-157880: Write visible headers of BabylMessage in mailbox.Babyl - #157881
Merged
Merged
Conversation
vasiliyk
force-pushed
the
gh-157880-babyl
branch
from
October 22, 2026 00:45
54ee57d to
718d11f
Compare
serhiy-storchaka
self-requested a review
October 22, 2026 12:37
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
Thank you for the patch. The fix looks good to me.
Please add a test for a message with no visible headers. It is also broken, because the blank line after the headers is not written, and get_bytes() fails with AssertionError.
Contributor
Author
|
Added |
serhiy-storchaka
added
needs backport to 3.14
|
Thanks @vasiliyk for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
GH-160276 is a backport of this pull request to the 3.15 branch. |
|
GH-160277 is a backport of this pull request to the 3.14 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding a BabylMessage, Babyl._install_message() flattens its visible headers into a BytesIO and copies them line by line into the mailbox file. The buffer was never rewound after flattening, so readline() returned nothing and the visible headers block and the blank line after it were skipped.
Reading the message back with get_message() or get_bytes() then consumed the body as headers and failed with AssertionError.
Rewind the buffer before reading it, and add a test that adds a BabylMessage with visible headers and reads it back.