Repository navigation
Add test for os.renames - #159657
Add test for os.renames#159657ste1hi wants to merge 4 commits into
os.renames#159657Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
picnixz
left a comment
There was a problem hiding this comment.
I don't think the tests for random are relevant. It's a garbage-in/garbage-out case. For os.renames, it makes sense (and I'm surprised we didn't have a test!)
|
I removed the test for random.sample |
|
Thank you for your interest in contributing to Python. This is a community-driven project, and we want it to be a welcoming place to learn and collaborate. Contributors are responsible for reviewing and understanding what they submit, checking its claims, and being able to explain changes in their own words. This helps reviewers focus on the contribution and leaves more time to support other contributors. This contribution appears to have been authored with AI assistance. Please explain your contribution in your own words and describe how you checked its correctness. Please read our guidelines for using AI tools. |
|
@StanFromIreland This PR doesn't look like AI I guess? |
|
I suppose, it's hard to tell sometimes. |
os.renames
|
I really did NOT use any AI assistant. Btw, I think there is no need to use AI for this simple case. ExplanationI made a file named Just curious, I want to know why you think I used AI assistant and how can I prove that I have not used AI assitant. |
|
That's fine, I'm sorry I didn't intend it as an insult or such thing. What I am curious about however, is how you checked coverage? What are the statistics before/after? |
|
I think the coverage checking is simple using coverage.py. FTR, we don't even test os.renames at all in the file (i did a Crtl+F of os.renames itself) |


Inprove random.sample test. Add tests for when the items in the list are not integers.
Add test for os.rename function.