Skip to content

[3.15] gh-159123: fix ResourceWarning flake in asyncio SSL handshake failure tests (GH-160209) #160225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 1 commit into from
Oct 22, 2026
+16 −10
Merged

[3.15] gh-159123: fix ResourceWarning flake in asyncio SSL handshake failure tests (GH-160209) #160225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions Lib/test/test_asyncio/test_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1202,12 +1202,13 @@ def test_create_server_ssl_verify_failed(self):
'(?i)certificate.verify.failed'):
self.loop.run_until_complete(f_c)

# execute the loop to log the connection error
test_utils.run_briefly(self.loop)
# close connection: wait until the server-side transport of the
# failed handshake is closed as well, otherwise its socket may
# still be open when the loop is closed (gh-159123).
server.close()
self.loop.run_until_complete(server.wait_closed())

# close connection
self.assertIsNone(proto.transport)
server.close()

@socket_helper.skip_unless_bind_unix_socket
@unittest.skipIf(ssl is None, 'No ssl module')
Expand All @@ -1232,12 +1233,13 @@ def test_create_unix_server_ssl_verify_failed(self):
'(?i)certificate.verify.failed'):
self.loop.run_until_complete(f_c)

# execute the loop to log the connection error
test_utils.run_briefly(self.loop)
# close connection: wait until the server-side transport of the
# failed handshake is closed as well, otherwise its socket may
# still be open when the loop is closed (gh-159123).
server.close()
self.loop.run_until_complete(server.wait_closed())

# close connection
self.assertIsNone(proto.transport)
server.close()

@unittest.skipIf(ssl is None, 'No ssl module')
def test_create_server_ssl_match_failed(self):
Expand Down Expand Up @@ -1268,10 +1270,14 @@ def test_create_server_ssl_match_failed(self):
with self.assertRaisesRegex(ssl.CertificateError, regex):
self.loop.run_until_complete(f_c)

# close connection
# close connection: wait until the server-side transport of the
# failed handshake is closed as well, otherwise its socket may
# still be open when the loop is closed (gh-159123).
server.close()
self.loop.run_until_complete(server.wait_closed())

# transport is None because TLS ALERT aborted the handshake
self.assertIsNone(proto.transport)
server.close()

@socket_helper.skip_unless_bind_unix_socket
@unittest.skipIf(ssl is None, 'No ssl module')
Expand Down
Loading