Repository navigation
gh-69968: Prevent cycles in the __context__ chain. - #20543
Draft
serhiy-storchaka wants to merge 2 commits into
Draft
serhiy-storchaka wants to merge 2 commits into
serhiy-storchaka wants to merge 2 commits into
Conversation
serhiy-storchaka
added
type-bug
pablogsal
reviewed
Apr 23, 2021
Comment on lines
+605
to
+606
| If *ctx* is *ex*, the function has no any effect. If *ex* is in the | ||
| context chain started from *ctx*, it is moved to the start of the chain. |
Member
There was a problem hiding this comment.
Suggested change
| If *ctx* is *ex*, the function has no any effect. If *ex* is in the | |
| context chain started from *ctx*, it is moved to the start of the chain. | |
| If *ctx* is *ex*, the function has no effect. If *ex* is in the | |
| context chain started from *ctx*, it is moved to the start of the chain. |
pablogsal
reviewed
Apr 23, 2021
Comment on lines
+71
to
+73
| Setting :attr:`__context__` to self has no any effect. If set | ||
| ``__context__`` to the chain contained original exception, it is moved to | ||
| the start of the context chain. |
Member
There was a problem hiding this comment.
Suggested change
| Setting :attr:`__context__` to self has no any effect. If set | |
| ``__context__`` to the chain contained original exception, it is moved to | |
| the start of the context chain. | |
| Setting :attr:`__context__` to self has no effect. If set | |
| ``__context__`` to the chain contained an original exception, it is moved to | |
| the start of the context chain. |
rhettinger
approved these changes
May 10, 2022
Contributor
|
This missed the boat for inclusion in Python 3.9 which accepts security fixes only as of today. |
|
This PR is stale because it has been open for 30 days with no activity. |
serhiy-storchaka
changed the title
github-actions
Bot
removed
the
stale
Setting __context__ to self has no any effect. If set __context__ to the chain contained original exception, it is moved to the start of the context chain.
ambv
force-pushed
the
set-context-reordering
branch
from
October 20, 2026 21:01
a87b7ed to
5d32953
Compare
Documentation build overview
4 files changed± builtins/exceptions.html± c-api/exceptions.html± library/ast.html± whatsnew/changelog.html |
|
All commit authors signed the Contributor License Agreement. |
…thongh-69968) Py_END_CRITICAL_SECTION() emits a closing brace, so calling it inside the nested if/while early-return path closed the wrong block and left 'base_self' undeclared after the loop. Restructure to a single exit: record the cycle with a flag, then release the lock before Py_DECREF. Also add the missing news entry. Co-authored-by: Muse Code (Meta Muse Spark)
ambv
force-pushed
the
set-context-reordering
branch
from
October 21, 2026 01:52
e0f22af to
167dab3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting
__context__to self has no any effect. If set__context__to the chain contained original exception, it is moved to the start of the context chain.https://bugs.python.org/issue25782